Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Real.ENNReal #2388

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Data.Real.ENNReal #2388

wants to merge 8 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 20, 2023 •
edited by github-actions bot

I did some fixes/refactors while working on this PR. I'm going to move them to new PRs soon.

Open in Gitpod

@urkud urkud added awaiting-author A reviewer has asked the author a question or requested changes mathlib-port This is a port of a theory file from mathlib. labels Feb 20, 2023
@semorrison semorrison added blocked-by-math-PR This PR depends on another PR to Mathlib merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-math-PR This PR depends on another PR to Mathlib labels Feb 20, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Feb 20, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 20, 2023
@casavaca casavaca mentioned this pull request Feb 21, 2023
Closed
1 task
@urkud urkud mentioned this pull request Feb 23, 2023
Closed
@urkud urkud added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Feb 25, 2023
@urkud urkud mentioned this pull request Feb 25, 2023
Closed
4 tasks
@semorrison semorrison added blocked-by-math-PR This PR depends on another PR to Mathlib and removed blocked-by-math-PR This PR depends on another PR to Mathlib labels Feb 25, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@urkud
feat: port Data.Real.Ennreal
28f0c52
@urkud
Initial file copy from mathport
64ddf1a
@urkud
automated fixes
137608b 
Mathbin -> Mathlib

fix certain import statements

move "by" to end of line

add import to Mathlib.lean
@urkud
Rename file
a6c8976 
Also fix `import`s
@urkud
Fix Ennreal → ENNReal, Nnreal → NNReal
68e2d75
@urkud
Snapshot
62ff9dd
This was referenced Feb 26, 2023
Closed
Closed
jcommelin
jcommelin reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Mathlib/Data/Real/ENNReal.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Feb 27, 2023

✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Feb 27, 2023
@urkud
Copy link
Member Author

urkud commented Feb 27, 2023

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Feb 27, 2023
bors bot pushed a commit that referenced this pull request Feb 27, 2023
@urkud
feat: port Data.Real.ENNReal (#2388)
1979f8d 
I did some fixes/refactors while working on this PR. I'm going to move them to new PRs soon.
@bors
Copy link

bors bot commented Feb 27, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Real.ENNReal [Merged by Bors] - feat: port Data.Real.ENNReal Feb 27, 2023
@bors bors bot closed this Feb 27, 2023
@bors bors bot deleted the port/Data.Real.Ennreal branch February 27, 2023 08:23
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Feb 27, 2023
@urkud
chore(data/real/ennreal): drop some lemmas (#18501)
57ac39b 
Drop lemmas that are in fact more general lemmas applied to `ennreal`.

For now, these lemmas are marked as `@[deprecated]` in leanprover-community/mathlib4#2388.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urkud @semorrison @jcommelin