Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Data.Real.EReal #2501

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - feat: port Data.Real.EReal #2501

wants to merge 10 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Feb 26, 2023 •
edited by github-actions bot

@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Feb 27, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2023
@joneugster joneugster added the mathlib-port This is a port of a theory file from mathlib. label Feb 27, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Feb 27, 2023
@urkud urkud added the awaiting-review The author would like community review of the PR label Feb 27, 2023
@urkud urkud changed the title feat: port Data.Real.Ereal feat: port Data.Real.EReal Feb 27, 2023
jcommelin
jcommelin approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Feb 28, 2023
bors bot pushed a commit that referenced this pull request Feb 28, 2023
@urkud
feat: port Data.Real.EReal (#2501)
127bbb2
@bors
Copy link

bors bot commented Feb 28, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Data.Real.EReal [Merged by Bors] - feat: port Data.Real.EReal Feb 28, 2023
@bors bors bot closed this Feb 28, 2023
@bors bors bot deleted the port/Data.Real.Ereal branch February 28, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @semorrison @jcommelin @joneugster