Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port SetTheory.Ordinal.Notation #2470

Closed
wants to merge 86 commits into from
Closed

[Merged by Bors] - feat: port SetTheory.Ordinal.Notation #2470

wants to merge 86 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Feb 23, 2023 •
edited by github-actions bot

@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. help-wanted The author needs attention to resolve issues labels Feb 23, 2023
@mo271 mo271 removed the WIP Work in progress label Mar 8, 2023
@joneugster joneugster mentioned this pull request Mar 27, 2023
Closed
@joneugster joneugster force-pushed the port/SetTheory.Ordinal.Notation branch from 9f18380 to 6908018 Compare March 28, 2023 06:58
@joneugster
Copy link
Collaborator

I just rebased this to the newest master, but I don't actually manage to make any progress :(

@vihdzp
Copy link
Collaborator

vihdzp commented Apr 9, 2023

I'll make an attempt to clean up the Mathlib 3 file. Hopefully that helps porting this file.

@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/SetTheory.Ordinal.Notation branch from 6908018 to da3d246 Compare May 23, 2023 19:31
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR which is still in the queue. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels May 23, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Ruben-VandeVelde Ruben-VandeVelde force-pushed the port/SetTheory.Ordinal.Notation branch from da3d246 to 5ad4141 Compare May 24, 2023 07:14
@Ruben-VandeVelde
Copy link
Collaborator

I'll make an attempt to clean up the Mathlib 3 file. Hopefully that helps porting this file.

Any news, @vihdzp ?

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 20, 2023
joneugster
joneugster reviewed Jun 20, 2023
View reviewed changes
Mathlib/SetTheory/Ordinal/Notation.lean Outdated
Comment on lines 32 to 38
open Ordinal Order

open Ordinal

-- Porting note: the generated theorem gets lint.
set_option genSizeOfSpec false in
-- get notation for `ω`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
open Ordinal Order
open Ordinal
-- Porting note: the generated theorem gets lint.
set_option genSizeOfSpec false in
-- get notation for `ω`
open Ordinal Order
-- Porting note: the generated theorem gets lint.
set_option genSizeOfSpec false in

The mathlib3 source had

open ordinal order
open_locale ordinal -- get notation for `ω`

that's where the comment comes from

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the comment has now vanished from the source. Could it be restored, please?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even without the notation for ω, open Ordinal is required.
And, in Lean 4, when an namespace is opened, its locale is automatically opened too, so open_locale ordinal and the comment is not needed anymore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sorry to be slow.

@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 20, 2023
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
@Komyyy Komyyy added awaiting-review The author would like community review of the PR awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 21, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 21, 2023
bors bot pushed a commit that referenced this pull request Jun 21, 2023
@mo271 @arienmalec
@joneugster @Ruben-VandeVelde @apurvnakade @Komyyy
feat: port SetTheory.Ordinal.Notation (#2470)
7eebe3d 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Apurva Nakade <apurvnakade@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
@bors
Copy link

bors bot commented Jun 21, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port SetTheory.Ordinal.Notation [Merged by Bors] - feat: port SetTheory.Ordinal.Notation Jun 21, 2023
@bors bors bot closed this Jun 21, 2023
@bors bors bot deleted the port/SetTheory.Ordinal.Notation branch June 21, 2023 05:31
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@mo271 @arienmalec
@joneugster @Ruben-VandeVelde @apurvnakade @Komyyy @alexkeizer
feat: port SetTheory.Ordinal.Notation (#2470)
baf1a64 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Apurva Nakade <apurvnakade@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@mo271 @arienmalec
@joneugster @Ruben-VandeVelde @apurvnakade @Komyyy @semorrison
feat: port SetTheory.Ordinal.Notation (#2470)
0034b5e 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Apurva Nakade <apurvnakade@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@mo271 @arienmalec
@joneugster @Ruben-VandeVelde @apurvnakade @Komyyy @semorrison
feat: port SetTheory.Ordinal.Notation (#2470)
553d455 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Apurva Nakade <apurvnakade@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@mo271 @arienmalec
@joneugster @Ruben-VandeVelde @apurvnakade @Komyyy @semorrison
feat: port SetTheory.Ordinal.Notation (#2470)
6a24b33 
Co-authored-by: Arien Malec <arien.malec@gmail.com>
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: Jon Eugster <eugster.jon@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Apurva Nakade <apurvnakade@gmail.com>
Co-authored-by: Komyyy <pol_tta@outlook.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

@joneugster joneugster joneugster left review comments

@Komyyy Komyyy Komyyy left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@mo271 @joneugster @vihdzp @semorrison @Ruben-VandeVelde @Komyyy @Parcly-Taxel @arienmalec @LukasMias @apurvnakade