[Merged by Bors] - chore: strip trailing spaces in lean files #2828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
added
awaiting-review
Parcly-Taxel
approved these changes
Mar 12, 2023
|
Some people might have, by accident or intent, disabled the trailing space stripping, or they may be using other editors which do not implement trailing space stripping. |
|
Some people use neovim which might not remove trailing whitespace by default. |
|
bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Mar 12, 2023
vscode is already configured by `.vscode/settings.json` to trim these on save. It's not clear how they've managed to stick around. By doing this all in one PR now, it avoids getting random whitespace diffs in PRs later. This was done with a regex search in vscode, 
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode is already configured by
.vscode/settings.jsonto trim these on save. It's not clear how they've managed to stick around.By doing this all in one PR now, it avoids getting random whitespace diffs in PRs later.
This was done with a regex search in vscode,