[Merged by Bors] - fix: prevent Int.ofNat being used instead of Nat.cast
#2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this override, the coercion is found as `instCoeNatInt : Coe ℕ ℤ` which unfolds to `Int.ofNat`. This only happened when searching for `Coe ℕ ℤ`; `CoeHTCT ℕ ℤ` would already find the correct instance.
eric-wieser
added
the
awaiting-review
2 tasks
gebner
reviewed
Mar 14, 2023
| @@ -45,6 +45,9 @@ instance [NatCast R] : CoeTail ℕ R where coe := Nat.cast | |||
| -- see note [coercion into rings] | |||
| instance [NatCast R] : CoeHTCT ℕ R where coe := Nat.cast | |||
|
Right instance, but it should go into std4. |
|
Are you happy to add the instance in both places, and remove this one next time we bump std4? |
|
We already have two duplicated instances above it, so it doesn't change much. Please make a PR that adds the instance to std4 and a PR to remove the 2 (3) instances from mathlib4. In the meantime, feel free to |
|
✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
and removed
awaiting-review
|
bors merge I'll make the Std4 PR shortly |
bors bot
pushed a commit
that referenced
this pull request
Mar 14, 2023
Without this override, the coercion is found as `instCoeNatInt : Coe ℕ ℤ` which unfolds to `Int.ofNat`. This only happened when searching for `Coe ℕ ℤ`; `CoeHTCT ℕ ℤ` would already find the correct instance.
|
std4 PR is leanprover-community/batteries#107 |
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Int.ofNat being used instead of Nat.castInt.ofNat being used instead of Nat.cast
bors bot
pushed a commit
that referenced
this pull request
Mar 17, 2023
We bump std4 and take care to delete the now-upstreamed (leanprover-community/batteries#107) instances mentioned in #2878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this override, the coercion is found as
instCoeNatInt : Coe ℕ ℤwhich unfolds toInt.ofNat. This only happened when searching forCoe ℕ ℤ;CoeHTCT ℕ ℤwould already find the correct instance.