Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: prevent Int.ofNat being used instead of Nat.cast #2878

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - fix: prevent Int.ofNat being used instead of Nat.cast #2878

wants to merge 2 commits into from

Commits on Mar 14, 2023

  1. fix: prevent Int.ofNat being used instead of Nat.cast 

    Without this override, the coercion is found as `instCoeNatInt : Coe ℕ ℤ` which unfolds to `Int.ofNat`.
This only happened when searching for `Coe ℕ ℤ`; `CoeHTCT ℕ ℤ` would already find the correct instance.
    @eric-wieser
    eric-wieser committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d82ec2a View commit details
    Browse the repository at this point in the history

  2. fix the CanLift instance

    @eric-wieser
    eric-wieser committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    45d1ed3 View commit details
    Browse the repository at this point in the history