[Merged by Bors] - feat: port CategoryTheory.Limits.Shapes.Diagonal #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
…s.KernelPair' into port/CategoryTheory.Limits.Shapes.Diagonal
joelriou
added
mathlib-port
semorrison
added
the
blocked-by-other-PR
This was referenced Mar 15, 2023
semorrison
removed
the
blocked-by-other-PR
|
This PR/issue depends on:
|
joelriou
added
the
awaiting-review
| (by simp only [Category.assoc, diagonal_snd, Category.comp_id, pullback.lift_snd, | ||
| pullback.lift_snd_assoc, pullback.condition_assoc])) | ||
| hom_inv_id := by | ||
| apply pullback.hom_ext |
There was a problem hiding this comment.
Can these be fixed by setting priorities on the @[ext] attributes. In mathlib3 I think there were no priorities and the most recent thing was used first, but in mathlib4 we should be setting priorities to make this work. You can write @[ext 1100] to increase the priority, and the default is 1000.
There was a problem hiding this comment.
Thanks very much for this suggestion. Indeed, automation works much better now!
ChrisHughes24
added
awaiting-author
Parcly-Taxel
removed
the
awaiting-author
Parcly-Taxel
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded:
|
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a deterministic timeout which can be circumvented by
set_option maxHeartbeats 400000