Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.MorphismProperty #2909

Closed
wants to merge 22 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.MorphismProperty #2909

wants to merge 22 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Mar 15, 2023 •
edited by github-actions bot

@joelriou
feat: port CategoryTheory.Limits.Shapes.KernelPair
1fa830f
@joelriou
Initial file copy from mathport
e1dd851
@joelriou
automated fixes
c158e24 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou
it compiles
10e1265
@joelriou
added PushoutCocone.IsColimit.desc
6bc339c
@joelriou
feat: port CategoryTheory.Limits.Shapes.Diagonal
787dd56
@joelriou
Initial file copy from mathport
b41aca4
@joelriou
automated fixes
d827c86 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou
Merge remote-tracking branch 'origin/port/CategoryTheory.Limits.Shape…
c7388c2 
…s.KernelPair' into port/CategoryTheory.Limits.Shapes.Diagonal
@joelriou
started working on this file
ac7f3fc
@joelriou
it should compile
0acb2e6
@joelriou
feat: port CategoryTheory.MorphismProperty
259bcf8
@joelriou
Initial file copy from mathport
4dbc620
@joelriou
automated fixes
f7010f9 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Mar 15, 2023
@semorrison semorrison added the blocked-by-math-PR This PR depends on another PR to Mathlib label Mar 15, 2023
@joelriou joelriou mentioned this pull request Mar 15, 2023
Closed
3 tasks
@joelriou joelriou removed the WIP Work in progress label Mar 15, 2023
This was referenced Mar 16, 2023
Closed
Closed
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 22, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 22, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Mar 24, 2023
@Parcly-Taxel Parcly-Taxel removed blocked-by-math-PR This PR depends on another PR to Mathlib merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Mar 24, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. and removed easy < 20s of review time. See the lifecycle page for guidelines. labels Mar 24, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 24, 2023
bors bot pushed a commit that referenced this pull request Mar 24, 2023
@joelriou @Parcly-Taxel
feat: port CategoryTheory.MorphismProperty (#2909)
cf80a76 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 24, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.MorphismProperty [Merged by Bors] - feat: port CategoryTheory.MorphismProperty Mar 24, 2023
@bors bors bot closed this Mar 24, 2023
@bors bors bot deleted the port/CategoryTheory.MorphismProperty branch March 24, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelriou @semorrison @ChrisHughes24 @Parcly-Taxel