Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Fix Topology.Algebra.Order.UpperLower docstring #2896

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: Fix Topology.Algebra.Order.UpperLower docstring #2896

wants to merge 3 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label Mar 15, 2023
@YaelDillies YaelDillies mentioned this pull request Mar 15, 2023
Closed
7 tasks
@YaelDillies @Parcly-Taxel
fix docs
d164a98 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@eric-wieser
Copy link
Member

Needs a SHA update

@eric-wieser eric-wieser added the awaiting-author A reviewer has asked the author a question or requested changes label Mar 21, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes needs-mathlib-SHA labels Mar 21, 2023
eric-wieser
eric-wieser approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://leanprover-community.github.io/mathlib-port-status/file/topology/algebra/order/upper_lower?range=4330aae21f538b862f8aead371cfb6ee556398f1..992efbda6f85a5c9074375d3c7cb9764c64d8f72 looks good

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Mar 21, 2023
bors bot pushed a commit that referenced this pull request Mar 21, 2023
@YaelDillies @Parcly-Taxel
chore: Fix Topology.Algebra.Order.UpperLower docstring (#2896)
eae4bf3 
Match leanprover-community/mathlib#17257



Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Mar 21, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore: Fix Topology.Algebra.Order.UpperLower docstring [Merged by Bors] - chore: Fix Topology.Algebra.Order.UpperLower docstring Mar 21, 2023
@bors bors bot closed this Mar 21, 2023
@bors bors bot deleted the upper_lower_norm branch March 21, 2023 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@Parcly-Taxel Parcly-Taxel Parcly-Taxel approved these changes

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @eric-wieser @Parcly-Taxel @semorrison