Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: Fix Topology.Algebra.Order.UpperLower docstring #2896

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore: Fix Topology.Algebra.Order.UpperLower docstring #2896

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42644d1
chore: Fix `Topology.Algebra.Order.UpperLower` docstring
YaelDillies Mar 15, 2023
d164a98
fix docs
YaelDillies Mar 15, 2023
9b9f521
Ш
Parcly-Taxel Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions Mathlib/Topology/Algebra/Order/UpperLower.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ Released under Apache 2.0 license as described in the file LICENSE.
Authors: Yaël Dillies

! This file was ported from Lean 3 source module topology.algebra.order.upper_lower
! leanprover-community/mathlib commit 4330aae21f538b862f8aead371cfb6ee556398f1
! leanprover-community/mathlib commit 992efbda6f85a5c9074375d3c7cb9764c64d8f72
! Please do not edit these lines, except to modify the commit id
! if you have ported upstream changes.
-/
Expand All @@ -18,11 +18,10 @@ The topological closure and interior of an upper/lower/order-connected set is an
upper/lower/order-connected set (with the notable exception of the closure of an order-connected
set).

## Notes
## Implementation notes

The lemmas don't mention additive/multiplicative operations. As a result, we decide to prime the
multiplicative lemma names to indicate that there is probably a common generalisation to each pair
of additive/multiplicative lemma.
The same lemmas are true in the additive/multiplicative worlds. To avoid code duplication, we
provide `HasUpperLowerClosure`, an ad hoc axiomatisation of the properties we need.
-/


Expand Down