Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port LinearAlgebra.DirectSum.Finsupp #3205

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat: port LinearAlgebra.DirectSum.Finsupp #3205

wants to merge 5 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

Open in Gitpod

@Parcly-Taxel
feat: port LinearAlgebra.DirectSum.Finsupp
25da833
@Parcly-Taxel
Initial file copy from mathport
b913593
@Parcly-Taxel
automated fixes
0bebda1 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Parcly-Taxel
Fix errors
dcbe1cd
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Mar 31, 2023
dupuisf
dupuisf reviewed Apr 1, 2023
View reviewed changes
Mathlib/LinearAlgebra/DirectSum/Finsupp.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/DirectSum/Finsupp.lean Outdated Show resolved Hide resolved
Mathlib/LinearAlgebra/DirectSum/Finsupp.lean Outdated Show resolved Hide resolved
@dupuisf dupuisf added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 1, 2023
@Parcly-Taxel @dupuisf
Address review comments
772f3a9 
Co-authored-by: Frédéric Dupuis <31101893+dupuisf@users.noreply.github.com>
@Parcly-Taxel Parcly-Taxel added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 1, 2023
dupuisf
dupuisf reviewed Apr 1, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 1, 2023
bors bot pushed a commit that referenced this pull request Apr 1, 2023
@Parcly-Taxel
feat: port LinearAlgebra.DirectSum.Finsupp (#3205)
196e4a1 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 1, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port LinearAlgebra.DirectSum.Finsupp [Merged by Bors] - feat: port LinearAlgebra.DirectSum.Finsupp Apr 1, 2023
@bors bors bot closed this Apr 1, 2023
@bors bors bot deleted the port/LinearAlgebra.DirectSum.Finsupp branch April 1, 2023 22:30
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@Parcly-Taxel @MonadMaverick
feat: port LinearAlgebra.DirectSum.Finsupp (#3205)
dfcd9da 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@Parcly-Taxel @MonadMaverick
feat: port LinearAlgebra.DirectSum.Finsupp (#3205)
59c3344 
Co-authored-by: Parcly Taxel <reddeloostw@gmail.com>
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Parcly-Taxel @dupuisf @semorrison