Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Category.PartOrd #3266

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - feat: port Order.Category.PartOrd #3266

wants to merge 13 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Apr 4, 2023 •
edited by github-actions bot

@joelriou
feat: port Order.Category.Preord
d94b59d
@joelriou
Initial file copy from mathport
e5b9931
@joelriou
automated fixes
33e7aba 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou
it compiles
167c1e9
@joelriou
updated Mathlib.lean
a04c844
@joelriou
feat: port Order.Category.PartOrd
16f698a
@joelriou
Initial file copy from mathport
82b2594
@joelriou
automated fixes
779b3fd 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 4, 2023
@semorrison semorrison added the blocked-by-math-PR This PR depends on another PR to Mathlib label Apr 4, 2023
@joelriou joelriou removed the WIP Work in progress label Apr 4, 2023
@joelriou joelriou mentioned this pull request Apr 4, 2023
Closed
2 tasks
@semorrison semorrison removed the blocked-by-math-PR This PR depends on another PR to Mathlib label Apr 5, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Parcly-Taxel Parcly-Taxel added the awaiting-review The author would like community review of the PR label Apr 5, 2023
@ChrisHughes24
Copy link
Member

@joelriou It makes it a lot easier to review if whenever you change the name of a file, you do so in a commit that makes no other changes, and preferably the first commit. It's difficult to see the diff with the mathport output otherwise.

This was referenced Apr 5, 2023
Closed
Closed
Closed
@ChrisHughes24
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 5, 2023
bors bot pushed a commit that referenced this pull request Apr 5, 2023
@joelriou
feat: port Order.Category.PartOrd (#3266)
c84577c
@bors
Copy link

bors bot commented Apr 5, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Order.Category.PartOrd [Merged by Bors] - feat: port Order.Category.PartOrd Apr 5, 2023
@bors bors bot closed this Apr 5, 2023
@bors bors bot deleted the port/Order.Category.PartOrd branch April 5, 2023 13:20
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@joelriou @MonadMaverick
feat: port Order.Category.PartOrd (#3266)
fee5cd7
MonadMaverick pushed a commit that referenced this pull request Apr 9, 2023
@joelriou @MonadMaverick
feat: port Order.Category.PartOrd (#3266)
ecd36e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelriou @semorrison @ChrisHughes24 @Parcly-Taxel