Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port AlgebraicTopology.SimplexCategory #3286

Closed
wants to merge 44 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Apr 5, 2023


Introducing two lemmas Fin.ite_val and Fin.dite_val, the simplicial relations are now obtained in a slightly cleaner way as compared to mathlib. Everything is translated into equalities of natural numbers on a case by case basis using split_ifs, simp and linarith.

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 5, 2023
…inOrd' into port/AlgebraicTopology.SimplexCategory
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Apr 5, 2023
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. labels Apr 5, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 5, 2023
@joelriou joelriou added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 5, 2023
@ChrisHughes24
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Apr 6, 2023
bors bot pushed a commit that referenced this pull request Apr 6, 2023
@bors
Copy link

bors bot commented Apr 6, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port AlgebraicTopology.SimplexCategory [Merged by Bors] - feat: port AlgebraicTopology.SimplexCategory Apr 6, 2023
@bors bors bot closed this Apr 6, 2023
@bors bors bot deleted the port/AlgebraicTopology.SimplexCategory branch April 6, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants