-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port AlgebraicTopology.SimplexCategory #3286
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
…o port/Order.Category.Lat
… port/Order.Category.PartOrd
…o port/Order.Category.Lat
…o port/Order.Category.Lat
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
…rt/Order.Category.LinOrd
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
… port/Order.Category.NonemptyFinLinOrd
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
joelriou
added
WIP
Work in progress
mathlib-port
This is a port of a theory file from mathlib.
labels
Apr 5, 2023
…inOrd' into port/AlgebraicTopology.SimplexCategory
semorrison
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
label
Apr 5, 2023
semorrison
added
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
and removed
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
labels
Apr 5, 2023
This PR/issue depends on: |
semorrison
removed
the
merge-conflict
The PR has a merge conflict with master, and needs manual merging.
label
Apr 5, 2023
joelriou
added
awaiting-review
The author would like community review of the PR
and removed
WIP
Work in progress
labels
Apr 5, 2023
2 tasks
bors r+ |
github-actions
bot
added
ready-to-merge
This PR has been sent to bors.
and removed
awaiting-review
The author would like community review of the PR
labels
Apr 6, 2023
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat: port AlgebraicTopology.SimplexCategory
[Merged by Bors] - feat: port AlgebraicTopology.SimplexCategory
Apr 6, 2023
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
MonadMaverick
pushed a commit
that referenced
this pull request
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
mathlib-port
This is a port of a theory file from mathlib.
ready-to-merge
This PR has been sent to bors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing two lemmas
Fin.ite_val
andFin.dite_val
, the simplicial relations are now obtained in a slightly cleaner way as compared to mathlib. Everything is translated into equalities of natural numbers on a case by case basis usingsplit_ifs
,simp
andlinarith
.