Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Sites.Closed #3356

Closed
wants to merge 14 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Sites.Closed #3356

wants to merge 14 commits into from

Conversation

mo271
Copy link
Collaborator

@mo271 mo271 commented Apr 9, 2023

Open in Gitpod

@mo271
feat: port CategoryTheory.Sites.Closed
1ac62eb
@mo271
Initial file copy from mathport
0475e6b
@mo271
automated fixes
f903887 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@mo271
starting
ef35f5b
@mo271 mo271 added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 9, 2023
@mo271
Copy link
Collaborator Author

mo271 commented Apr 9, 2023 •
edited

TODO:

  • Functor.closedSieves: seems aesop is not able to fill the missing _.
  • classifier_isSheaf: simp_rw [← c] doesn't to the intended subsitution, probably because a type is involved.
  • naming in comments

@mo271 mo271 added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Apr 9, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 27, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Apr 29, 2023
@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 10, 2023
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label May 15, 2023
@int-y1
Copy link
Collaborator

int-y1 commented May 30, 2023

The error with Functor.closedSieves no longer exists

@int-y1 int-y1 removed the help-wanted The author needs attention to resolve issues label May 30, 2023
@mo271 mo271 added the awaiting-review The author would like community review of the PR label May 30, 2023
@semorrison
Copy link
Contributor

bors d+

@bors
Copy link

bors bot commented May 30, 2023

✌️ mo271 can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated and removed awaiting-review The author would like community review of the PR labels May 30, 2023
@mo271 @semorrison
Update Mathlib/CategoryTheory/Sites/Closed.lean
f213e45 
Co-authored-by: Scott Morrison <scott@tqft.net>
@mo271
Copy link
Collaborator Author

mo271 commented May 31, 2023

bors r+

bors bot pushed a commit that referenced this pull request May 31, 2023
@mo271 @int-y1
feat: port CategoryTheory.Sites.Closed (#3356)
ad4e7a8 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented May 31, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 31, 2023
@mo271 @int-y1
feat: port CategoryTheory.Sites.Closed (#3356)
0cbb9b8 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
@bors
Copy link

bors bot commented May 31, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Sites.Closed [Merged by Bors] - feat: port CategoryTheory.Sites.Closed May 31, 2023
@bors bors bot closed this May 31, 2023
@bors bors bot deleted the port/CategoryTheory.Sites.Closed branch May 31, 2023 06:03
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@mo271 @int-y1 @qawbecrdtey
feat: port CategoryTheory.Sites.Closed (leanprover-community#3356)
ab309d0 
Co-authored-by: Moritz Firsching <firsching@google.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mo271 @int-y1 @semorrison