[Merged by Bors] - fix: Fix Polynomial.repr
#3442
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komyyy
added
awaiting-review
|
Can you add some tests for this? You can get computable output with #eval (鉄ㄢ煥{0, 2}, Pi.single 0 11 + Pi.single 2 22, sorry鉄┾煩 : 鈩昜X]) |
|
This works well. C 11 + C 22 * X ^ 2 |
|
Thanks 馃帀 bors merge |
github-actions
bot
added
ready-to-merge
I mean actually put something in the |
bors bot
pushed a commit
that referenced
this pull request
Apr 20, 2023
I misunderstood the `Repr` instance when I port this file, In Lean 4, `Repr` returns `Format`, not `String`, so my porting of `Polynomial.repr` was unnatural. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net>
eric-wieser
reviewed
Apr 20, 2023
|
bors r- |
|
Canceled. |
eric-wieser
force-pushed
the
Polynomial.repr
branch
from
94a78ea
to
31fd182
Compare
jcommelin
reviewed
Apr 21, 2023
Komyyy
added
the
awaiting-review
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Apr 22, 2023
I misunderstood the `Repr` instance when I port this file, In Lean 4, `Repr` returns `Format`, not `String`, so my porting of `Polynomial.repr` was unnatural. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Polynomial.reprPolynomial.repr
kbuzzard
pushed a commit
that referenced
this pull request
Apr 22, 2023
I misunderstood the `Repr` instance when I port this file, In Lean 4, `Repr` returns `Format`, not `String`, so my porting of `Polynomial.repr` was unnatural. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
semorrison
pushed a commit
that referenced
this pull request
May 10, 2023
I misunderstood the `Repr` instance when I port this file, In Lean 4, `Repr` returns `Format`, not `String`, so my porting of `Polynomial.repr` was unnatural. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 10, 2023
I misunderstood the `Repr` instance when I port this file, In Lean 4, `Repr` returns `Format`, not `String`, so my porting of `Polynomial.repr` was unnatural. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
hrmacbeth
pushed a commit
that referenced
this pull request
May 11, 2023
I misunderstood the `Repr` instance when I port this file, In Lean 4, `Repr` returns `Format`, not `String`, so my porting of `Polynomial.repr` was unnatural. Co-authored-by: Eric Wieser <wieser.eric@gmail.com> Co-authored-by: Johan Commelin <johan@commelin.net> Co-authored-by: Pol_tta <52843868+Komyyy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I misunderstood the
Reprinstance when I port this file, In Lean 4,ReprreturnsFormat, notString, so my porting ofPolynomial.reprwas unnatural.I fixed that in this PR. Of course,
Polynomialis noncomputable and this instance is actually useless. 馃ゴ