Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - fix: Fix Polynomial.repr #3442

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - fix: Fix Polynomial.repr #3442

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
16c1613
refactor
Komyyy Apr 15, 2023
9256295
make computable
eric-wieser Apr 15, 2023
8373401
fix typo
eric-wieser Apr 15, 2023
3fcbff6
add test cases
jcommelin Apr 20, 2023
31fd182
move tests
eric-wieser Apr 20, 2023
707981c
precedence
eric-wieser Apr 20, 2023
b19d9c8
add space
Komyyy Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 18 additions & 4 deletions Mathlib/Data/Polynomial/Basic.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,10 +1221,10 @@ section repr
variable [Semiring R]

protected instance repr [Repr R] [DecidableEq R] : Repr R[X] :=
⟨fun p prec =>
⟨fun p _ =>
if p.support = ∅ then "0"
else
Repr.addAppParen
Lean.Format.paren
semorrison marked this conversation as resolved.
Show resolved Hide resolved
(Lean.Format.fill
(Lean.Format.joinSep
(List.map
Expand All @@ -1235,10 +1235,24 @@ protected instance repr [Repr R] [DecidableEq R] : Repr R[X] :=
if coeff p n = 1 then "X ^ " ++ Nat.repr n
else "C " ++ reprArg (coeff p n) ++ " * X ^ " ++ Nat.repr n)
(p.support.sort (· ≤ ·)))
(" +" ++ Lean.Format.line)))
prec⟩
(" +" ++ Lean.Format.line)))⟩
#align polynomial.has_repr Polynomial.repr

example : reprStr
(⟨⟨{}, Pi.single 0 0,
by intro; simp [Pi.single, Function.update_apply]⟩⟩ : ℕ[X]) =
"0" := by native_decide

example : reprStr
(⟨⟨{1}, Pi.single 1 37,
by intro; simp [Pi.single, Function.update_apply]⟩⟩ : ℕ[X]) =
"(C 37 * X)" := by native_decide

example : reprStr
(⟨⟨{0, 2}, Pi.single 0 57 + Pi.single 2 22,
by intro; simp [Pi.single, Function.update_apply]; tauto⟩⟩ : ℕ[X]) =
"(C 57 + C 22 * X ^ 2)" := by native_decide

end repr

end Polynomial