Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port CategoryTheory.Subobject.FactorThru #3445

Closed
wants to merge 15 commits into from

Conversation

joelriou
Copy link
Collaborator

@joelriou joelriou commented Apr 15, 2023

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joelriou joelriou added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Apr 15, 2023
…sic' into port/CategoryTheory.Subobject.FactorThru
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Apr 15, 2023
Co-authored-by: Scott Morrison <scott@tqft.net>
@semorrison
Copy link
Contributor

bors d+

Please merge these in order.

@bors
Copy link

bors bot commented Apr 17, 2023

✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Apr 17, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@joelriou
Copy link
Collaborator Author

Thanks @semorrison for all these reviews!

bors r+

bors bot pushed a commit that referenced this pull request Apr 17, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Apr 17, 2023

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port CategoryTheory.Subobject.FactorThru [Merged by Bors] - feat: port CategoryTheory.Subobject.FactorThru Apr 17, 2023
@bors bors bot closed this Apr 17, 2023
@bors bors bot deleted the port/CategoryTheory.Subobject.FactorThru branch April 17, 2023 16:52
semorrison pushed a commit that referenced this pull request May 10, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants