New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat: port CategoryTheory.Subobject.FactorThru #3445
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
joelriou
commented
Apr 15, 2023
•
edited by github-actions
bot
edited by github-actions
bot
- depends on: [Merged by Bors] - feat: port CategoryTheory.Subobject.Basic #3444
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
Mathbin -> Mathlib fix certain import statements move "by" to end of line add import to Mathlib.lean
joelriou
added
WIP
Work in progress
mathlib-port
This is a port of a theory file from mathlib.
labels
Apr 15, 2023
…sic' into port/CategoryTheory.Subobject.FactorThru
semorrison
added
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
label
Apr 15, 2023
This was referenced Apr 15, 2023
Co-authored-by: Scott Morrison <scott@tqft.net>
bors d+ Please merge these in order. |
✌️ joelriou can now approve this pull request. To approve and merge a pull request, simply reply with |
…sic' into port/CategoryTheory.Subobject.FactorThru
semorrison
removed
the
blocked-by-other-PR
This PR depends on another PR which is still in the queue.
label
Apr 17, 2023
This PR/issue depends on:
|
Thanks @semorrison for all these reviews! bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
feat: port CategoryTheory.Subobject.FactorThru
[Merged by Bors] - feat: port CategoryTheory.Subobject.FactorThru
Apr 17, 2023
semorrison
pushed a commit
that referenced
this pull request
May 10, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.