Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.NormedSpace.Units #3856

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Analysis.NormedSpace.Units #3856

wants to merge 9 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented May 8, 2023

Open in Gitpod

urkud added 5 commits May 8, 2023 16:09
@urkud
feat: port Analysis.NormedSpace.Units
0d2166a
@urkud
Initial file copy from mathport
6d48ebe
@urkud
automated fixes
20f56bc 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@urkud
Start fixing
1975d74
@urkud
Fix more
69632f7
@int-y1 int-y1 added the mathlib-port This is a port of a theory file from mathlib. label May 10, 2023
@urkud urkud added the awaiting-review The author would like community review of the PR label May 11, 2023
dupuisf
dupuisf reviewed May 12, 2023
View reviewed changes
Copy link
Contributor

@dupuisf dupuisf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 12, 2023
bors bot pushed a commit that referenced this pull request May 12, 2023
@urkud
feat: port Analysis.NormedSpace.Units (#3856)
c01ced8
@bors
Copy link

bors bot commented May 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.NormedSpace.Units [Merged by Bors] - feat: port Analysis.NormedSpace.Units May 12, 2023
@bors bors bot closed this May 12, 2023
@bors bors bot deleted the port/Analysis.NormedSpace.Units branch May 12, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dupuisf dupuisf dupuisf left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@urkud @dupuisf @semorrison @int-y1