Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18983 #4001

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#18983 #4001

wants to merge 2 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde commented May 15, 2023 •
edited by github-actions bot

@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label May 15, 2023
@Ruben-VandeVelde Ruben-VandeVelde force-pushed the forward-port-18983 branch 2 times, most recently from 460bc67 to d65ae4a Compare May 15, 2023 15:15
@eric-wieser eric-wieser added the mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged label May 16, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label May 22, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-review The author would like community review of the PR label May 22, 2023
eric-wieser
eric-wieser approved these changes May 22, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

Thanks!

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels May 22, 2023
bors bot pushed a commit that referenced this pull request May 22, 2023
@Ruben-VandeVelde
chore: forward-port leanprover-community/mathlib#18983 (#4001)
9039a67
@bors
Copy link

bors bot commented May 22, 2023

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 22, 2023
@Ruben-VandeVelde
chore: forward-port leanprover-community/mathlib#18983 (#4001)
2b47ec0
@bors
Copy link

bors bot commented May 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#18983 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#18983 May 22, 2023
@bors bors bot closed this May 22, 2023
@bors bors bot deleted the forward-port-18983 branch May 22, 2023 18:33
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @qawbecrdtey
chore: forward-port leanprover-community/mathlib#18983 (leanprover-co…
5baadb5 
…mmunity#4001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @semorrison @eric-wieser