Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Analysis.Analytic.Basic #4275

Closed
wants to merge 20 commits into from
Closed

[Merged by Bors] - feat: port Analysis.Analytic.Basic #4275

wants to merge 20 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port Analysis.Analytic.Basic
143ce94
@Ruben-VandeVelde
Initial file copy from mathport
dd90e8e
@Ruben-VandeVelde
automated fixes
dfe04ae 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
Fixes
84c42ef
@Ruben-VandeVelde
Fixes
9e8a535
@Ruben-VandeVelde Ruben-VandeVelde added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels May 23, 2023
@Ruben-VandeVelde Ruben-VandeVelde added please-adopt and removed WIP Work in progress labels May 23, 2023
@adomani adomani added help-wanted The author needs attention to resolve issues and removed please-adopt labels May 28, 2023
@int-y1
Copy link
Collaborator

int-y1 commented May 30, 2023 •
edited by j-loreaux

todo:

  • (optional) in the docs, find the translation for formal_multilinear_series.mk_pi_field
  • nnnorm_changeOriginSeries_le_tsum sorry

@j-loreaux j-loreaux added awaiting-review and removed help-wanted The author needs attention to resolve issues labels May 31, 2023
jcommelin
jcommelin reviewed Jun 1, 2023
View reviewed changes
Mathlib/Analysis/Analytic/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Analytic/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Analytic/Basic.lean Outdated Show resolved Hide resolved
Mathlib/Analysis/Analytic/Basic.lean Outdated Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 1, 2023
bors bot pushed a commit that referenced this pull request Jun 1, 2023
@Ruben-VandeVelde @adomani
@int-y1 @j-loreaux @jcommelin
feat: port Analysis.Analytic.Basic (#4275)
f7b4507 
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 1, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Analysis.Analytic.Basic [Merged by Bors] - feat: port Analysis.Analytic.Basic Jun 1, 2023
@bors bors bot closed this Jun 1, 2023
@bors bors bot deleted the port/Analysis.Analytic.Basic branch June 1, 2023 16:44
qawbecrdtey pushed a commit to qawbecrdtey/greedoid-mathlib4 that referenced this pull request Jun 12, 2023
@Ruben-VandeVelde @adomani
@int-y1 @j-loreaux @jcommelin @qawbecrdtey
feat: port Analysis.Analytic.Basic (leanprover-community#4275)
f94375b 
Co-authored-by: adomani <adomani@gmail.com>
Co-authored-by: int-y1 <jason_yuen2007@hotmail.com>
Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin left review comments

@adomani adomani adomani left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ruben-VandeVelde @int-y1 @jcommelin @adomani @j-loreaux