[Merged by Bors] - feat: golf using gcongr throughout the library #4784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hrmacbeth
added
the
awaiting-review
jcommelin
reviewed
Jun 7, 2023
Co-authored-by: Johan Commelin <johan@commelin.net>
|
this is amazing |
|
🚀 Pull request has been placed on the maintainer queue by mcdoll. |
|
Thanks! 🎉 |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 8, 2023
Following on from #4702, another hundred sample uses of the `gcongr` tactic.
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
qawbecrdtey
pushed a commit
to qawbecrdtey/greedoid-mathlib4
that referenced
this pull request
Jun 12, 2023
…4784) Following on from leanprover-community#4702, another hundred sample uses of the `gcongr` tactic.
mathlib-bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2023
Following on from previous `gcongr` golfing PRs #4702 and #4784. This is a replacement for #7901: this round of golfs, first introduced there, there exposed some performance issues in `gcongr`, hopefully fixed by #8731, and I am opening a new PR so that the performance can be checked against current master rather than master at the time of #7901.
awueth
pushed a commit
that referenced
this pull request
Dec 19, 2023
Following on from previous `gcongr` golfing PRs #4702 and #4784. This is a replacement for #7901: this round of golfs, first introduced there, there exposed some performance issues in `gcongr`, hopefully fixed by #8731, and I am opening a new PR so that the performance can be checked against current master rather than master at the time of #7901.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #4702, another hundred sample uses of the
gcongrtactic.