New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: golf using gcongr throughout the library #7901
Conversation
!bench |
Here are the benchmark results for commit 3aed923. Benchmark Metric Change
==========================================================
- lint wall-clock 5.3%
- ~Mathlib.Analysis.Analytic.Inverse instructions 9.6% |
!bench |
Here are the benchmark results for commit 39161d1. Benchmark Metric Change
==========================================================
- ~Mathlib.Analysis.Analytic.Inverse instructions 10.1% |
!bench |
Here are the benchmark results for commit 2c84531. |
!bench |
Here are the benchmark results for commit 3a0bde1. |
!bench |
Here are the benchmark results for commit 5b38eba. |
!bench |
Here are the benchmark results for commit 818206f. Benchmark Metric Change
==========================================================
- ~Mathlib.Analysis.Analytic.Inverse instructions 8.4% |
Closing in favour of #8752. |
Following on from previous `gcongr` golfing PRs #4702 and #4784. This is a replacement for #7901: this round of golfs, first introduced there, there exposed some performance issues in `gcongr`, hopefully fixed by #8731, and I am opening a new PR so that the performance can be checked against current master rather than master at the time of #7901.
Following on from previous `gcongr` golfing PRs #4702 and #4784. This is a replacement for #7901: this round of golfs, first introduced there, there exposed some performance issues in `gcongr`, hopefully fixed by #8731, and I am opening a new PR so that the performance can be checked against current master rather than master at the time of #7901.
Following on from #4702 and #4784.