Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: port Order.Category.SemilatCat #4990

Closed
wants to merge 13 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jun 12, 2023


#3918 (seems to have no impact here, although it touches relevant files. They can be merged in arbitrary order)

Open in Gitpod

Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joneugster joneugster added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 12, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR to Mathlib label Jun 12, 2023
@joneugster joneugster added awaiting-review The author would like community review of the PR and removed WIP Work in progress blocked-by-other-PR This PR depends on another PR to Mathlib labels Jun 12, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR to Mathlib label Jun 12, 2023
@joneugster joneugster removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Jun 12, 2023
@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 13, 2023
@joneugster
Copy link
Collaborator Author

applied all suggestions above

@joneugster joneugster added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 13, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new docstrings weren't quite accurate.

Mathlib/Order/Category/SemilatCat.lean Outdated Show resolved Hide resolved
Mathlib/Order/Category/SemilatCat.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 13, 2023
bors bot pushed a commit that referenced this pull request Jun 13, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented Jun 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Order.Category.SemilatCat [Merged by Bors] - feat: port Order.Category.SemilatCat Jun 13, 2023
@bors bors bot closed this Jun 13, 2023
@bors bors bot deleted the port/Order.Category.Semilat branch June 13, 2023 10:57
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants