Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Category.BoolAlgCat #5023

Closed
wants to merge 7 commits into from
Closed

[Merged by Bors] - feat: port Order.Category.BoolAlgCat #5023

wants to merge 7 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jun 13, 2023 •
edited

@joneugster joneugster added WIP Work in progress blocked-by-math-PR This PR depends on another PR to Mathlib mathlib-port This is a port of a theory file from mathlib. awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 13, 2023
This was referenced Jun 14, 2023
Closed
Closed
@semorrison semorrison added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-math-PR This PR depends on another PR to Mathlib labels Jun 14, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 14, 2023
semorrison
semorrison reviewed Jun 15, 2023
View reviewed changes
Mathlib/Order/Category/BoolAlgCat.lean
Comment on lines +81 to +84
-- Porting note: was `fun {X Y} f => show BoundedLatticeHom X Y from f`
-- which already looks like a hack, but I don't understand why this hack works now and
-- the old one didn't
map := fun {X Y} (f : BoundedLatticeHom X Y) => show HeytingHom X Y from f }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also do not understand!

@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 15, 2023
bors bot pushed a commit that referenced this pull request Jun 15, 2023
@joneugster
feat: port Order.Category.BoolAlgCat (#5023)
ac61d01
@bors
Copy link

bors bot commented Jun 15, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Order.Category.BoolAlgCat [Merged by Bors] - feat: port Order.Category.BoolAlgCat Jun 15, 2023
@bors bors bot closed this Jun 15, 2023
@bors bors bot deleted the port/Order.Category.BoolAlg branch June 15, 2023 03:18
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@joneugster @alexkeizer
feat: port Order.Category.BoolAlgCat (#5023)
be02739
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@joneugster @semorrison
feat: port Order.Category.BoolAlgCat (#5023)
b9c0f03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joneugster @semorrison