Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Order.Category.FinBoolAlgCat #5052

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat: port Order.Category.FinBoolAlgCat #5052

wants to merge 9 commits into from

Conversation

joneugster
Copy link
Collaborator

@joneugster joneugster commented Jun 14, 2023 •
edited by semorrison
Loading

@joneugster joneugster added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 14, 2023
@semorrison semorrison added blocked-by-other-PR This PR depends on another PR to Mathlib merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Jun 14, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

@joneugster joneugster force-pushed the port/Order.Category.FinBoolAlg branch from 2272636 to d856c3a Compare June 15, 2023 12:43
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Jun 15, 2023
@joneugster joneugster added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 15, 2023
@j-loreaux
Copy link
Collaborator

The FunLike instance that was added seems suspicious; not that it's the wrong function, just that I suspect it only causes further issues.

@semorrison
Copy link
Contributor

I've replaced the FunLike instance with a BoundedLatticeHomClass instance.

I've also added a note saying that we should go back and refactor the earlier bundled order categories to use this formulation. As we are now at a mathlib3 leaf, there's no need to do this now.

@semorrison semorrison added awaiting-review and removed help-wanted The author needs attention to resolve issues labels Jun 15, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Jun 16, 2023
bors bot pushed a commit that referenced this pull request Jun 16, 2023
@joneugster
feat: port Order.Category.FinBoolAlgCat (#5052)
bef1721 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
@bors
Copy link

bors bot commented Jun 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port Order.Category.FinBoolAlgCat [Merged by Bors] - feat: port Order.Category.FinBoolAlgCat Jun 16, 2023
@bors bors bot closed this Jun 16, 2023
@bors bors bot deleted the port/Order.Category.FinBoolAlg branch June 16, 2023 05:40
jcommelin pushed a commit that referenced this pull request Jun 17, 2023
@joneugster @jcommelin
feat: port Order.Category.FinBoolAlgCat (#5052)
02c9992 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
alexkeizer pushed a commit that referenced this pull request Jun 22, 2023
@joneugster @alexkeizer
feat: port Order.Category.FinBoolAlgCat (#5052)
eb45d5f 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@joneugster @semorrison
feat: port Order.Category.FinBoolAlgCat (#5052)
6c3614a 
Co-authored-by: Scott Morrison <scott.morrison@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joneugster @semorrison @j-loreaux @jcommelin