Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port CategoryTheory.Monad.Monadicity #5088

Closed
wants to merge 21 commits into from
Closed

[Merged by Bors] - feat: port CategoryTheory.Monad.Monadicity #5088

wants to merge 21 commits into from

Conversation

joneugster
Copy link
Collaborator

Open in Gitpod

@joneugster
feat: port CategoryTheory.Monad.Monadicity
e827cfd
@joneugster
Initial file copy from mathport
85346b5
@joneugster
automated fixes
f442d6d 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@joneugster joneugster added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 15, 2023
@joneugster joneugster added help-wanted The author needs attention to resolve issues and removed WIP Work in progress labels Jun 21, 2023
@semorrison
Copy link
Contributor

I've merged master, so we have access to allowSynthFailures in the newer lean it depends on.

@semorrison semorrison mentioned this pull request Jul 7, 2023
Open
1 task
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed help-wanted The author needs attention to resolve issues labels Jul 11, 2023
@mattrobball
Copy link
Collaborator

The synthFailure config didn't seem very useful. Refactored parametered instances into classes as suggested on Zulip.

@semorrison
Copy link
Contributor

It does look like the Lean 4 fix that will allow us to keep the parametrized instances may be merged soon (Leo asked for a comment added explaining the patch). I think it's fine to revert the instance design later, in any case, so there's no particular need to wait.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 12, 2023
@mattrobball mattrobball added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 12, 2023
@semorrison
Copy link
Contributor

I pushed a few bits of cleanup.

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 12, 2023
bors bot pushed a commit that referenced this pull request Jul 12, 2023
@joneugster @thorimur
@kbuzzard @semorrison @mattrobball
feat: port CategoryTheory.Monad.Monadicity (#5088)
1e93cf2 
Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
@bors
Copy link

bors bot commented Jul 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port CategoryTheory.Monad.Monadicity [Merged by Bors] - feat: port CategoryTheory.Monad.Monadicity Jul 12, 2023
@bors bors bot closed this Jul 12, 2023
@bors bors bot deleted the port/CategoryTheory.Monad.Monadicity branch July 12, 2023 04:02
This was referenced Jul 12, 2023
Closed
Closed
semorrison added a commit that referenced this pull request Aug 14, 2023
@joneugster @thorimur
@kbuzzard @semorrison @mattrobball
feat: port CategoryTheory.Monad.Monadicity (#5088)
817bd3f 
Co-authored-by: thorimur <68410468+thorimur@users.noreply.github.com>
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Matthew Ballard <matt@mrb.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmill kmill kmill left review comments

@semorrison semorrison semorrison left review comments

@mattrobball mattrobball mattrobball left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@joneugster @semorrison @mattrobball @kmill @thorimur @kbuzzard