Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - cleanup: in Monadicity, restore local notation analogue and a mathlib3 comment #5826

Closed
wants to merge 1 commit into from

Conversation

kmill
Copy link
Contributor

@kmill kmill commented Jul 12, 2023

The notation3 command supports referring to local variables if you give it local, unlike notation. These notations should not be made unhygienic and scoped.


Open in Gitpod

…3 comments

The `notation3` command supports referring to local variables if you give it `local`, unlike `notation`. These notations should not be made unhygienic and `scoped`.
@kmill kmill requested a review from semorrison July 12, 2023 06:46
@kmill kmill added the awaiting-review The author would like community review of the PR label Jul 12, 2023
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 12, 2023
@@ -282,6 +272,10 @@ variable [IsRightAdjoint G]

section BeckMonadicity

-- Porting note: these local notations were not used in this section before
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have not leaked. It was my fault (probably) in #5088. Fixed in #5830. Same below

bors bot pushed a commit that referenced this pull request Jul 12, 2023
…ib3 comment (#5826)

The `notation3` command supports referring to local variables if you give it `local`, unlike `notation`. These notations should not be made unhygienic and `scoped`.
@bors
Copy link

bors bot commented Jul 12, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title cleanup: in Monadicity, restore local notation analogue and a mathlib3 comment [Merged by Bors] - cleanup: in Monadicity, restore local notation analogue and a mathlib3 comment Jul 12, 2023
@bors bors bot closed this Jul 12, 2023
@bors bors bot deleted the kmill_monadicity branch July 12, 2023 11:49
semorrison pushed a commit that referenced this pull request Aug 14, 2023
…ib3 comment (#5826)

The `notation3` command supports referring to local variables if you give it `local`, unlike `notation`. These notations should not be made unhygienic and `scoped`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants