Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port RingTheory.DedekindDomain.SInteger #5401

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat: port RingTheory.DedekindDomain.SInteger #5401

wants to merge 6 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde
feat: port RingTheory.DedekindDomain.SInteger
f8e5db6
@Ruben-VandeVelde
Initial file copy from mathport
64d4c09
@Ruben-VandeVelde
automated fixes
457b50f 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@Ruben-VandeVelde
1
67aef89
@Ruben-VandeVelde
Automated
0ca6861
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. awaiting-CI labels Jun 22, 2023
jcommelin
jcommelin approved these changes Jun 22, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

If CI passes, please remove the label awaiting-CI and merge this yourself, by adding a comment bors r+.

bors d+

@bors
Copy link

bors bot commented Jun 22, 2023

✌️ Ruben-VandeVelde can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jun 22, 2023
@Ruben-VandeVelde
Copy link
Collaborator Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 22, 2023
@Ruben-VandeVelde
feat: port RingTheory.DedekindDomain.SInteger (#5401)
4221b15
@bors
Copy link

bors bot commented Jun 22, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port RingTheory.DedekindDomain.SInteger [Merged by Bors] - feat: port RingTheory.DedekindDomain.SInteger Jun 22, 2023
@bors bors bot closed this Jun 22, 2023
@bors bors bot deleted the port/RingTheory.DedekindDomain.SInteger branch June 22, 2023 21:37
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@Ruben-VandeVelde @semorrison
feat: port RingTheory.DedekindDomain.SInteger (#5401)
fada7dc
semorrison pushed a commit that referenced this pull request Jun 23, 2023
@Ruben-VandeVelde @semorrison
feat: port RingTheory.DedekindDomain.SInteger (#5401)
03a75d3
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@Ruben-VandeVelde @semorrison
feat: port RingTheory.DedekindDomain.SInteger (#5401)
71027a5
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@Ruben-VandeVelde @kbuzzard
feat: port RingTheory.DedekindDomain.SInteger (#5401)
bcc14f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
delegated mathlib-port This is a port of a theory file from mathlib.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @jcommelin @semorrison