Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port NumberTheory.Cyclotomic.Rat #5417

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - feat: port NumberTheory.Cyclotomic.Rat #5417

wants to merge 15 commits into from

Conversation

riccardobrasca
Copy link
Member

@riccardobrasca riccardobrasca commented Jun 23, 2023 •
edited by github-actions bot

@riccardobrasca
feat: port NumberTheory.Cyclotomic.Rat
80ac9b4
@riccardobrasca
Initial file copy from mathport
bfeeebf
@riccardobrasca
automated fixes
576c1be 
Mathbin -> Mathlib
fix certain import statements
move "by" to end of line
add import to Mathlib.lean
@riccardobrasca riccardobrasca added WIP Work in progress mathlib-port This is a port of a theory file from mathlib. labels Jun 23, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 23, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 23, 2023
@semorrison semorrison added the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 23, 2023
@riccardobrasca riccardobrasca added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Jun 23, 2023
@jcommelin jcommelin changed the title Port/NumberTheory.Cyclotomic.Rat feat: port NumberTheory.Cyclotomic.Rat Jun 24, 2023
@semorrison semorrison removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Jun 24, 2023
@semorrison
Copy link
Contributor

This PR/issue depends on:

jcommelin
jcommelin approved these changes Jun 24, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jun 24, 2023
bors bot pushed a commit that referenced this pull request Jun 24, 2023
@riccardobrasca
feat: port NumberTheory.Cyclotomic.Rat (#5417)
4df50f9
@bors
Copy link

bors bot commented Jun 24, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: port NumberTheory.Cyclotomic.Rat [Merged by Bors] - feat: port NumberTheory.Cyclotomic.Rat Jun 24, 2023
@bors bors bot closed this Jun 24, 2023
@bors bors bot deleted the port/NumberTheory.Cyclotomic.Rat branch June 24, 2023 07:23
semorrison pushed a commit that referenced this pull request Jun 25, 2023
@riccardobrasca @semorrison
feat: port NumberTheory.Cyclotomic.Rat (#5417)
1123031
semorrison pushed a commit that referenced this pull request Jun 28, 2023
@riccardobrasca @semorrison
feat: port NumberTheory.Cyclotomic.Rat (#5417)
fc92b78
kbuzzard pushed a commit that referenced this pull request Jul 6, 2023
@riccardobrasca @kbuzzard
feat: port NumberTheory.Cyclotomic.Rat (#5417)
947f4c2
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@riccardobrasca @semorrison
feat: port NumberTheory.Cyclotomic.Rat (#5417)
df1f699
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardobrasca @semorrison @jcommelin