Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: forward port leanprover-community/mathlib#19128 #5791

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: forward port leanprover-community/mathlib#19128 #5791

wants to merge 8 commits into from

Conversation

ADedecker
Copy link
Member

@ADedecker ADedecker commented Jul 10, 2023 •
edited by eric-wieser

@ADedecker ADedecker added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jul 10, 2023
@eric-wieser eric-wieser changed the title feat: foward port 19128 feat: foward port leanprover-community/mathlib#19128 Jul 10, 2023
@eric-wieser eric-wieser changed the title feat: foward port leanprover-community/mathlib#19128 feat: forward port leanprover-community/mathlib#19128 Jul 10, 2023
urkud
urkud reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@urkud urkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Otherwise LGTM.
bors d+

Mathlib/Topology/Algebra/Module/StrongTopology.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Algebra/Module/StrongTopology.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 10, 2023

✌️ ADedecker can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@semorrison semorrison added delegated and removed awaiting-review The author would like community review of the PR labels Jul 10, 2023
@ADedecker
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jul 10, 2023
@ADedecker @Parcly-Taxel
feat: forward port leanprover-community/mathlib#19128 (#5791)
63e0da0 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
@bors
Copy link

bors bot commented Jul 10, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: forward port leanprover-community/mathlib#19128 [Merged by Bors] - feat: forward port leanprover-community/mathlib#19128 Jul 10, 2023
@bors bors bot closed this Jul 10, 2023
@bors bors bot deleted the forward-port-19128 branch July 10, 2023 16:16
@Ruben-VandeVelde Ruben-VandeVelde mentioned this pull request Jul 14, 2023
Closed
bors bot pushed a commit that referenced this pull request Jul 14, 2023
@Ruben-VandeVelde
chore: forward-port leanprover-community/mathlib#19128 (#5905)
1cc977d 
The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.
kbuzzard pushed a commit that referenced this pull request Jul 15, 2023
@Ruben-VandeVelde @kbuzzard
chore: forward-port leanprover-community/mathlib#19128 (#5905)
ee6439b 
The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@ADedecker @Parcly-Taxel @semorrison
feat: forward port leanprover-community/mathlib#19128 (#5791)
ae42abc 
Co-authored-by: Jeremy Tan Jie Rui <reddeloostw@gmail.com>
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Ruben-VandeVelde @semorrison
chore: forward-port leanprover-community/mathlib#19128 (#5905)
bcd7faa 
The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urkud urkud urkud left review comments

Assignees
No one assigned
Labels
delegated mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ADedecker @urkud @semorrison @Parcly-Taxel