Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19128 #5905

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - chore: forward-port leanprover-community/mathlib#19128 #5905

wants to merge 1 commit into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.

Open in Gitpod

@Ruben-VandeVelde
chore: forward-port leanprover-community/mathlib#19128
c982640 
The changed proof was rewritten completely.
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review The author would like community review of the PR mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged labels Jul 14, 2023
eric-wieser
eric-wieser approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

I'll take your word for it; at any rate, forward-porting changes within proofs hardly matters at this stage, as all it's really for is downstream projects which only see statements.

@semorrison semorrison added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Jul 14, 2023
bors bot pushed a commit that referenced this pull request Jul 14, 2023
@Ruben-VandeVelde
chore: forward-port leanprover-community/mathlib#19128 (#5905)
1cc977d 
The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.
@bors
Copy link

bors bot commented Jul 14, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore: forward-port leanprover-community/mathlib#19128 [Merged by Bors] - chore: forward-port leanprover-community/mathlib#19128 Jul 14, 2023
@bors bors bot closed this Jul 14, 2023
@bors bors bot deleted the forward-port-19128 branch July 14, 2023 18:12
kbuzzard pushed a commit that referenced this pull request Jul 15, 2023
@Ruben-VandeVelde @kbuzzard
chore: forward-port leanprover-community/mathlib#19128 (#5905)
ee6439b 
The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.
semorrison pushed a commit that referenced this pull request Aug 14, 2023
@Ruben-VandeVelde @semorrison
chore: forward-port leanprover-community/mathlib#19128 (#5905)
bcd7faa 
The changed proof was rewritten completely.

There appears to have been a race between #5791 and #5727 that caused the commit hash to be out of date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
mathlib3-pair This PR is a forward-port of a mathlib3 PR or part of one, either under review or recently merged ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ruben-VandeVelde @eric-wieser @semorrison