[Merged by Bors] - chore(FieldTheory/Adjoin): remove unnecessary assumptions in minpolynatDegree_le and minpoly.degree_le
#6152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….natDegree_le` and `minpoly.degree_le` Also - fix the names of `minpoly.natDegree_le` and `minpoly.degree_le`. - rename `minpoly.ne_zero_of_finite_field_extension` to `minpoly.ne_zero_of_finite ` - rename `minpoly.ne_zero_of_finite_field_extension` to `minpoly.ne_zero_of_finite ` - reduce typeclass assumptions of some lemmas in `RingTheory/Algebraic` - add two lemmas `isIntegral_of_finite` and `isAlgebraic_of_finite` - move `Algebra.isIntegral_of_finite` to `RingTheory/IntegralClosure`
negiizhao
added
awaiting-review
|
maintainer merge |
|
🚀 Pull request has been placed on the maintainer queue by tb65536. |
|
Thanks! bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
…natDegree_le` and `minpoly.degree_le` (#6152) Also - fix the names of `minpoly.natDegree_le` and `minpoly.degree_le` - rename `minpoly.ne_zero_of_finite_field_extension` to `minpoly.ne_zero_of_finite` - reduce typeclass assumptions of some lemmas in `RingTheory/Algebraic` - add two lemmas `isIntegral_of_finite` and `isAlgebraic_of_finite` - move `Algebra.isIntegral_of_finite` to `RingTheory/IntegralClosure`
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
minpolynatDegree_le and minpoly.degree_leminpolynatDegree_le and minpoly.degree_le
semorrison
pushed a commit
that referenced
this pull request
Aug 14, 2023
…natDegree_le` and `minpoly.degree_le` (#6152) Also - fix the names of `minpoly.natDegree_le` and `minpoly.degree_le` - rename `minpoly.ne_zero_of_finite_field_extension` to `minpoly.ne_zero_of_finite` - reduce typeclass assumptions of some lemmas in `RingTheory/Algebraic` - add two lemmas `isIntegral_of_finite` and `isAlgebraic_of_finite` - move `Algebra.isIntegral_of_finite` to `RingTheory/IntegralClosure`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
minpoly.natDegree_leandminpoly.degree_leminpoly.ne_zero_of_finite_field_extensiontominpoly.ne_zero_of_finiteRingTheory/AlgebraicisIntegral_of_finiteandisAlgebraic_of_finiteAlgebra.isIntegral_of_finitetoRingTheory/IntegralClosure