Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(FieldTheory/Adjoin): remove unnecessary assumptions in minpolynatDegree_le and minpoly.degree_le #6152

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(FieldTheory/Adjoin): remove unnecessary assumptions in minpolynatDegree_le and minpoly.degree_le #6152

wants to merge 3 commits into from

Commits on Jul 26, 2023

  1. chore(FieldTheory/Adjoin): remove unnecessary assumptions in `minpoly… 

    ….natDegree_le` and `minpoly.degree_le`

Also
- fix the names of `minpoly.natDegree_le` and  `minpoly.degree_le`.
- rename `minpoly.ne_zero_of_finite_field_extension` to `minpoly.ne_zero_of_finite `
- rename `minpoly.ne_zero_of_finite_field_extension` to `minpoly.ne_zero_of_finite `
- reduce typeclass assumptions of some lemmas in `RingTheory/Algebraic`
- add two lemmas `isIntegral_of_finite` and `isAlgebraic_of_finite`
- move `Algebra.isIntegral_of_finite` to `RingTheory/IntegralClosure`
    @FR-vdash-bot
    FR-vdash-bot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    dde1b42 View commit details
    Browse the repository at this point in the history

  2. oops

    @FR-vdash-bot
    FR-vdash-bot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    4d9f941 View commit details
    Browse the repository at this point in the history

  3. fix

    @FR-vdash-bot
    FR-vdash-bot committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    74ea187 View commit details
    Browse the repository at this point in the history