Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(Algebra/Hom/GroupAction): add initialize_simps_projections #6343

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 3, 2023

Without this change the lemmas were called *_toFun instead of *_apply.

These lines should go immediately after the (transitive) FunLike instance is configured.

This PR also tidies some whitespace around wheres.


Open in Gitpod

@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. t-algebra Algebra (groups, rings, fields etc) labels Aug 3, 2023
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 6, 2023
bors bot pushed a commit that referenced this pull request Aug 6, 2023
…6343)

Without this change the lemmas were called `*_toFun` instead of `*_apply`.

These lines should go immediately after the (transitive) `FunLike` instance is configured.

This PR also tidies some whitespace around `where`s.
@bors
Copy link

bors bot commented Aug 6, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Algebra/Hom/GroupAction): add initialize_simps_projections [Merged by Bors] - chore(Algebra/Hom/GroupAction): add initialize_simps_projections Aug 6, 2023
@bors bors bot closed this Aug 6, 2023
@bors bors bot deleted the eric-wieser/missing-simps branch August 6, 2023 03:13
semorrison pushed a commit that referenced this pull request Aug 14, 2023
…6343)

Without this change the lemmas were called `*_toFun` instead of `*_apply`.

These lines should go immediately after the (transitive) `FunLike` instance is configured.

This PR also tidies some whitespace around `where`s.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants