New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - refactor(LinearAlgebra/Matrix/PosDef): Generalize to StarOrderedRing #6489
Conversation
This PR/issue depends on: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is mathematically sound. See, for instance, Takesaki's Theory of Operator Algebras, Volume 1, Lemma IV.3.2 where it is shown that a matrix with entries in a C⋆-algebra is positive (i.e., 0 ≤
with the order structure associated to the C⋆-algebra structure on those matrices) if and only if the matrix is positive semidefinite in the sense given in this PR. In fact, when I eventually get around to putting a (scoped) C⋆-algebra structure on matrices with entries in a C⋆-algebra, positive semidefiniteness is the order structure I'll use.
open scoped Matrix | ||
|
||
variable {𝕜 : Type*} [IsROrC 𝕜] | ||
variable {𝕜 : Type*} [CommRing 𝕜] [PartialOrder 𝕜] [StarOrderedRing 𝕜] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR: I was surprised to find that CommRing
is actually necessary here. And that's because it's necessary for, at least, A⁻¹
. That's a bit of a shame, because all this 2x2 Schur complement stuff (not involving determinants) should work in the non-commutative setting too (IIRC).
bors r+ |
…6489) I assume this is mathematically sound, though right now we can't generalize many dependencies due to the reliance of `InnerProductSpace`.
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
…6489) I assume this is mathematically sound, though right now we can't generalize many dependencies due to the reliance of `InnerProductSpace`.
I assume this is mathematically sound, though right now we can't generalize many dependencies due to the reliance of
InnerProductSpace
.