Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(LinearAlgebra/Matrix/PosDef): Generalize to StarOrderedRing #6489

Closed
wants to merge 9 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Aug 10, 2023

I assume this is mathematically sound, though right now we can't generalize many dependencies due to the reliance of InnerProductSpace.


Open in Gitpod

@eric-wieser eric-wieser added blocked-by-other-PR This PR depends on another PR which is still in the queue. awaiting-review The author would like community review of the PR awaiting-CI labels Aug 10, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. label Aug 10, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 10, 2023
@eric-wieser eric-wieser removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 10, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Aug 16, 2023
@eric-wieser eric-wieser added t-algebra Algebra (groups, rings, fields etc) and removed merge-conflict The PR has a merge conflict with master, and needs manual merging. labels Aug 16, 2023
Copy link
Collaborator

@j-loreaux j-loreaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is mathematically sound. See, for instance, Takesaki's Theory of Operator Algebras, Volume 1, Lemma IV.3.2 where it is shown that a matrix with entries in a C⋆-algebra is positive (i.e., 0 ≤ with the order structure associated to the C⋆-algebra structure on those matrices) if and only if the matrix is positive semidefinite in the sense given in this PR. In fact, when I eventually get around to putting a (scoped) C⋆-algebra structure on matrices with entries in a C⋆-algebra, positive semidefiniteness is the order structure I'll use.

open scoped Matrix

variable {𝕜 : Type*} [IsROrC 𝕜]
variable {𝕜 : Type*} [CommRing 𝕜] [PartialOrder 𝕜] [StarOrderedRing 𝕜]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to this PR: I was surprised to find that CommRing is actually necessary here. And that's because it's necessary for, at least, A⁻¹. That's a bit of a shame, because all this 2x2 Schur complement stuff (not involving determinants) should work in the non-commutative setting too (IIRC).

@j-loreaux
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Aug 16, 2023
bors bot pushed a commit that referenced this pull request Aug 16, 2023
…6489)

I assume this is mathematically sound, though right now we can't generalize many dependencies due to the reliance of `InnerProductSpace`.
@bors
Copy link

bors bot commented Aug 16, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title refactor(LinearAlgebra/Matrix/PosDef): Generalize to StarOrderedRing [Merged by Bors] - refactor(LinearAlgebra/Matrix/PosDef): Generalize to StarOrderedRing Aug 16, 2023
@bors bors bot closed this Aug 16, 2023
@bors bors bot deleted the eric-wieser/generalize-pos-def branch August 16, 2023 16:40
semorrison pushed a commit that referenced this pull request Aug 17, 2023
…6489)

I assume this is mathematically sound, though right now we can't generalize many dependencies due to the reliance of `InnerProductSpace`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants