Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Zagier's "one-sentence proof" of Fermat's theorem on sums of two squares #6629

Closed
wants to merge 32 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator


Open in Gitpod

@Parcly-Taxel Parcly-Taxel added awaiting-review t-number-theory Number theory (also use t-algebra or t-analysis to specialize) labels Aug 17, 2023
Co-authored-by: Moritz Firsching <firsching@google.com>
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
Mathlib/NumberTheory/Zagier.lean Outdated Show resolved Hide resolved
@tb65536
Copy link
Collaborator

tb65536 commented Aug 18, 2023

Here's a nice golf using Function.fixedPoints that avoids powers: zagier...zagier_golf

Co-authored-by: Thomas Browning <tb65536@uw.edu>
@Parcly-Taxel
Copy link
Collaborator Author

Here's a nice golf using Function.fixedPoints that avoids powers: zagier...zagier_golf

What a fantastic golf.

Parcly-Taxel and others added 2 commits August 19, 2023 02:43
Co-authored-by: Thomas Browning <tb65536@users.noreply.github.com>
Parcly-Taxel and others added 2 commits August 19, 2023 04:00
Co-authored-by: Thomas Browning <tb65536@uw.edu>
@ocfnash
Copy link
Contributor

ocfnash commented Aug 21, 2023

This is very nice but I suggest it would be be better placed in the archive folder, since we already have the result.

@Parcly-Taxel
Copy link
Collaborator Author

This is very nice but I suggest it would be be better placed in the archive folder, since we already have the result.

Done.

Copy link
Member

@mcdoll mcdoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please squeeze all of your nonterminal simps and add a bit more documentation in the proofs?

Archive/ZagierTwoSquares.lean Outdated Show resolved Hide resolved
@ocfnash
Copy link
Contributor

ocfnash commented Sep 2, 2023

The naming in Archive/ZagierTwoSquares is not what we would use in Mathlib proper (it's semantic rather than based on type) but as this is going in the archive, I think we can leave it as it is.

Thanks!

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Sep 2, 2023
bors bot pushed a commit that referenced this pull request Sep 2, 2023
@bors
Copy link

bors bot commented Sep 2, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Zagier's "one-sentence proof" of Fermat's theorem on sums of two squares [Merged by Bors] - feat: Zagier's "one-sentence proof" of Fermat's theorem on sums of two squares Sep 2, 2023
@bors bors bot closed this Sep 2, 2023
@bors bors bot deleted the zagier branch September 2, 2023 18:46
bors bot pushed a commit that referenced this pull request Sep 13, 2023
This was split from #6629 after @tb65536's golf, the construction here now no longer needed there. 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
This was split from #6629 after @tb65536's golf, the construction here now no longer needed there. 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-number-theory Number theory (also use t-algebra or t-analysis to specialize)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants