Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: group generated by a finite-order submonoid element #6648

Closed
wants to merge 11 commits into from

Conversation

Parcly-Taxel
Copy link
Collaborator

This was split from #6629 after @tb65536's golf, the construction here now no longer needed there.


Open in Gitpod

Parcly-Taxel and others added 2 commits August 18, 2023 18:07
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Mathlib/GroupTheory/Submonoid/Membership.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Submonoid/Membership.lean Outdated Show resolved Hide resolved
Mathlib/GroupTheory/Submonoid/Membership.lean Outdated Show resolved Hide resolved
@ocfnash ocfnash added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review labels Aug 23, 2023
@Parcly-Taxel Parcly-Taxel added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 23, 2023
Copy link
Contributor

@ocfnash ocfnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest relocating this to the file GroupTheory.OrderOfElement.

Mathlib/GroupTheory/Submonoid/Membership.lean Outdated Show resolved Hide resolved
@ocfnash
Copy link
Contributor

ocfnash commented Sep 13, 2023

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Sep 13, 2023
bors bot pushed a commit that referenced this pull request Sep 13, 2023
This was split from #6629 after @tb65536's golf, the construction here now no longer needed there. 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@bors
Copy link

bors bot commented Sep 13, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: group generated by a finite-order submonoid element [Merged by Bors] - feat: group generated by a finite-order submonoid element Sep 13, 2023
@bors bors bot closed this Sep 13, 2023
@bors bors bot deleted the submonoid_groupOfPowers branch September 13, 2023 11:20
kodyvajjha pushed a commit that referenced this pull request Sep 22, 2023
This was split from #6629 after @tb65536's golf, the construction here now no longer needed there. 



Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants