[Merged by Bors] - feat(Data/Sum/Basic): create direct versions of get(Left|Right)? analogous to Option.get #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
linesthatinterlace
commented
Aug 18, 2023
•
linesthatinterlace
commented
- [Merged by Bors] - fix(Data/Sum/Basic): Add ? to Sum-get function names. #6665
eric-wieser
reviewed
Aug 18, 2023
eric-wieser
reviewed
Aug 18, 2023
|
Would you mind splitting out a PR that adds the question marks and nothing else (ie, your first commit)? It will make the diff clearer. |
|
Oh, certainly. I assume I should keep this one up and just rebase it. I did my commits like that so it should actually be the first commit of this branch. |
|
I thought you might mean that but I wasn't sure and I thought better to do that first. |
|
See #6665. |
leanprover-community-mathlib4-bot
added
the
merge-conflict
eric-wieser
changed the title
eric-wieser
changed the title
eric-wieser
force-pushed
the
sum_get_direct
branch
from
9e3d06c
to
cb16396
Compare
leanprover-community-mathlib4-bot
removed
the
merge-conflict
|
Thanks 🎉 bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…ogous to Option.get (#6663) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Build failed (retrying...):
|
bors bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
…ogous to Option.get (#6663) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
ebab
pushed a commit
that referenced
this pull request
Sep 11, 2023
…ogous to Option.get (#6663) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
kodyvajjha
pushed a commit
that referenced
this pull request
Sep 22, 2023
…ogous to Option.get (#6663) Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.