Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: port Algebra.GroupWithZero.Basic #669

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - feat: port Algebra.GroupWithZero.Basic #669

wants to merge 8 commits into from

Conversation

Ruben-VandeVelde
Copy link
Collaborator

Tracking mathlib commit: 39af7d3bf61a98e928812dbc3e16f4ea8b795ca3

@Ruben-VandeVelde Ruben-VandeVelde added the mathlib-port This is a port of a theory file from mathlib. label Nov 20, 2022
@Ruben-VandeVelde Ruben-VandeVelde added the help-wanted The author needs attention to resolve issues label Nov 20, 2022
@Ruben-VandeVelde
Copy link
Collaborator Author

I somehow made the librarySearch test angry, but I'm not sure how.

@mcdoll
Copy link
Member

mcdoll commented Nov 21, 2022

Can you please please claim your ports over at https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status

@pechersky
Copy link
Collaborator

Can you please please claim your ports over at https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status

I've added it

@dwrensha dwrensha mentioned this pull request Nov 22, 2022
Closed
@Ruben-VandeVelde Ruben-VandeVelde added blocked-by-core-PR This PR depends on a PR to Core/Std and removed help-wanted The author needs attention to resolve issues labels Nov 23, 2022
@semorrison
Copy link
Contributor

The Lean 4 fix should arrive in nightly-2022-11-24.

@semorrison semorrison added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 24, 2022
@semorrison semorrison removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 24, 2022
@Ruben-VandeVelde Ruben-VandeVelde added awaiting-review and removed blocked-by-core-PR This PR depends on a PR to Core/Std labels Nov 25, 2022
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 25, 2022
bors bot pushed a commit that referenced this pull request Nov 25, 2022
@Ruben-VandeVelde @pechersky @semorrison
feat: port Algebra.GroupWithZero.Basic (#669)
79c0d38 
Tracking mathlib commit: [39af7d3bf61a98e928812dbc3e16f4ea8b795ca3](leanprover-community/mathlib@39af7d3)

Co-authored-by: Yakov Pechersky <ffxen158@gmail.com>
Co-authored-by: Scott Morrison <scott@tqft.net>
@bors
Copy link

bors bot commented Nov 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Algebra.GroupWithZero.Basic [Merged by Bors] - feat: port Algebra.GroupWithZero.Basic Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
@bors bors bot deleted the algebra.group_with_zero.basic branch November 25, 2022 16:50
@github-actions github-actions bot mentioned this pull request Nov 27, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 27, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17736)
28295cd 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.group.semiconj`: leanprover-community/mathlib4#717
* `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669
* `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722
* `algebra.ring.inj_surj`: leanprover-community/mathlib4#734
* `algebra.ring.units`: leanprover-community/mathlib4#746
* `data.finite.defs`: leanprover-community/mathlib4#698
* `order.lattice`: leanprover-community/mathlib4#642
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 27, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17736)
c7e627f 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.group.semiconj`: leanprover-community/mathlib4#717
* `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669
* `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722
* `algebra.ring.inj_surj`: leanprover-community/mathlib4#734
* `algebra.ring.units`: leanprover-community/mathlib4#746
* `data.finite.defs`: leanprover-community/mathlib4#698
* `order.lattice`: leanprover-community/mathlib4#642
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 28, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17736)
1fc36cc 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.group.semiconj`: leanprover-community/mathlib4#717
* `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669
* `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722
* `algebra.ring.inj_surj`: leanprover-community/mathlib4#734
* `algebra.ring.units`: leanprover-community/mathlib4#746
* `data.finite.defs`: leanprover-community/mathlib4#698
* `order.lattice`: leanprover-community/mathlib4#642
@github-actions github-actions bot mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@semorrison semorrison semorrison left review comments

Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ruben-VandeVelde @mcdoll @pechersky @semorrison