Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Algebra/Ring/InjSurj): port file #734

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(Algebra/Ring/InjSurj): port file #734

wants to merge 4 commits into from

Conversation

j-loreaux
Copy link
Collaborator

mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

porting notes: mostly smooth but:

  1. there were two places where I had to add MulZeroClass explicitly (toward the end of the file), which was weird
  2. one declaration is surprisingly slow for no apparent reason

@j-loreaux j-loreaux added awaiting-review The author would like community review of the PR mathlib-port This is a port of a theory file from mathlib. labels Nov 26, 2022
@semorrison
Copy link
Contributor

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review The author would like community review of the PR labels Nov 26, 2022
bors bot pushed a commit that referenced this pull request Nov 26, 2022
@j-loreaux
feat(Algebra/Ring/InjSurj): port file (#734)
d3ff87d 
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

porting notes: mostly smooth but:

1. there were two places where I had to add `MulZeroClass` explicitly (toward the end of the file), which was weird
2. one declaration is surprisingly slow for no apparent reason
@bors
Copy link

bors bot commented Nov 26, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(Algebra/Ring/InjSurj): port file [Merged by Bors] - feat(Algebra/Ring/InjSurj): port file Nov 26, 2022
@bors bors bot closed this Nov 26, 2022
@bors bors bot deleted the j-loreaux/algebra.ring.inj_surj branch November 26, 2022 05:46
@github-actions github-actions bot mentioned this pull request Nov 27, 2022
Closed
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 27, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17736)
28295cd 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.group.semiconj`: leanprover-community/mathlib4#717
* `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669
* `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722
* `algebra.ring.inj_surj`: leanprover-community/mathlib4#734
* `algebra.ring.units`: leanprover-community/mathlib4#746
* `data.finite.defs`: leanprover-community/mathlib4#698
* `order.lattice`: leanprover-community/mathlib4#642
rosborn added a commit that referenced this pull request Nov 27, 2022
@rosborn
Merge branch 'master' into Algebra.Order.Sub.Defs
6984444 
* master:
  feat: port Data.Countable.Defs (#736)
  chore: bump to nightly-2022-11-26 (#747)
  feat(Algebra/Ring/Units): port file (#746)
  style(Algebra/Order/Monoid/Lemmas): Update to current naming convention (#743)
  feat: stubs in ad-hoc ported files for linarith algebra requirements (#733)
  feat: port algebra.group.semiconj (#717)
  chore: make argument to mul_inv_cancel implicit (#737)
  feat(Algebra/Ring/InjSurj): port file (#734)
  chore: bump to nightly-2022-11-25 (#731)
  feat: port order.minmax (#728)
  chore: make the 'p' argument to Nat.find implicit (#730)
  feat: port Control.Basic (#588)
  feat: port data.finite.defs (#698)
  feat: port:  Data.DList.Basic (#616)
  chore: reduce imports in Algebra.Group.Defs (#727)
  chore(Algebra/Order/Hom/Basic): remove outParam (#692)
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 27, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17736)
c7e627f 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.group.semiconj`: leanprover-community/mathlib4#717
* `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669
* `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722
* `algebra.ring.inj_surj`: leanprover-community/mathlib4#734
* `algebra.ring.units`: leanprover-community/mathlib4#746
* `data.finite.defs`: leanprover-community/mathlib4#698
* `order.lattice`: leanprover-community/mathlib4#642
bors bot pushed a commit to leanprover-community/mathlib that referenced this pull request Nov 28, 2022
@leanprover-community-bot
chore(*): add mathlib4 synchronization comments (#17736)
1fc36cc 
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status).
Relates to the following PRs:
* `algebra.group.semiconj`: leanprover-community/mathlib4#717
* `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669
* `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722
* `algebra.ring.inj_surj`: leanprover-community/mathlib4#734
* `algebra.ring.units`: leanprover-community/mathlib4#746
* `data.finite.defs`: leanprover-community/mathlib4#698
* `order.lattice`: leanprover-community/mathlib4#642
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j-loreaux @semorrison