Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: generalize sheaf condition to only the relevant pullbacks existing #6750

Closed
wants to merge 2 commits into from

Conversation

dagurtomas
Copy link
Collaborator

We define a predicate Presieve.hasPullbacks which says that the pullback of every pair of arrows in the presieve exists. This allows to generalize Equalizer.Presieve.sheaf_condition to categories that don't necessarily have all pullbacks (such as Stonean).

Co-authored-by: Riccardo Brasca @riccardobrasca riccardo.brasca@gmail.com
Co-authored-by: Filippo A E Nuccio @faenuccio filippo.nuccio@univ-st-etienne.fr


Open in Gitpod

@dagurtomas
Copy link
Collaborator Author

@dagurtomas
Copy link
Collaborator Author

dagurtomas commented Aug 23, 2023

Instead of doing all the primed versions of the definitions and theorems in the Copenhagen repo, I provided an instance [R.hasPullbacks] given [HasPullbacks C] and generalized the existing versions.

@dagurtomas
Copy link
Collaborator Author

It's a bit annoying that Lean doesn't automatically find an instance for HasPullback f g given (hf : R f), (hg : R g) and [R.hasPullbacks]. Is there a way to fix this?

@dagurtomas
Copy link
Collaborator Author

It's a bit annoying that Lean doesn't automatically find an instance for HasPullback f g given (hf : R f), (hg : R g) and [R.hasPullbacks]. Is there a way to fix this?

And now the linter complains that there are unnecessary have statements...

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Aug 28, 2023
bors bot pushed a commit that referenced this pull request Aug 28, 2023
…ing (#6750)

We define a predicate `Presieve.hasPullbacks` which says that the pullback of every pair of arrows in the presieve exists. This allows to generalize `Equalizer.Presieve.sheaf_condition` to categories that don't necessarily have all pullbacks (such as `Stonean`). 

Co-authored-by: Riccardo Brasca @riccardobrasca [riccardo.brasca@gmail.com](mailto:riccardo.brasca@gmail.com)
Co-authored-by: Filippo A E Nuccio @faenuccio [filippo.nuccio@univ-st-etienne.fr](mailto:filippo.nuccio@univ-st-etienne.fr)
@bors
Copy link

bors bot commented Aug 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: generalize sheaf condition to only the relevant pullbacks existing [Merged by Bors] - feat: generalize sheaf condition to only the relevant pullbacks existing Aug 28, 2023
@bors bors bot closed this Aug 28, 2023
@bors bors bot deleted the dagur_PullbackPresieve branch August 28, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants