Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(Condensed): Explicit descriptions of condensed sets #6731

Closed
wants to merge 121 commits into from
Closed

[Merged by Bors] - feat(Condensed): Explicit descriptions of condensed sets #6731

wants to merge 121 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Aug 22, 2023 •
edited
Loading

We prove the characterisation of condensed sets as finite-product preserving presheaves satisfying the equalizer condition on CompHaus/Profinite, and just finite-product preserving presheaves on Stonean.

Co-authored-by: Riccardo Brasca @riccardobrasca riccardo.brasca@gmail.com
Co-authored-by: Filippo A E Nuccio @faenuccio filippo.nuccio@univ-st-etienne.fr

Open in Gitpod

@dagurtomas dagurtomas added the WIP Work in progress label Aug 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added blocked-by-other-PR This PR depends on another PR to Mathlib and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Aug 22, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib label Aug 23, 2023
@dagurtomas dagurtomas mentioned this pull request Nov 8, 2023
Closed
1 task
@dagurtomas dagurtomas changed the title feat: Explicit descriptions of condensed sets feat(Condensed): Explicit descriptions of condensed sets Nov 8, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added merge-conflict The PR has a merge conflict with master, and needs manual merging. and removed blocked-by-other-PR This PR depends on another PR to Mathlib labels Nov 14, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Nov 20, 2023
@dagurtomas dagurtomas added t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters t-condensed Condensed mathematics labels Nov 20, 2023
jcommelin
jcommelin reviewed Nov 21, 2023
View reviewed changes
Mathlib/Condensed/Explicit.lean

end Stonean

namespace Condensed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this maybe be CondensedSet? Because the results here are not about arbitrary Condensed FooBar, but specifically about CondensedSet. That would allow more use of dot-notation...
Has this been discussed before and/or is there some policy? I'm not aware of it...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target category should actually be more general. Then I can add versions for Type (u+1) in the CondensedSet namespace (maybe as abbrevs?)

jcommelin
jcommelin approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Dec 4, 2023
mathlib-bors bot pushed a commit that referenced this pull request Dec 4, 2023
@dagurtomas
feat(Condensed): Explicit descriptions of condensed sets (#6731)
d7f1e7f 
We prove the characterisation of condensed sets as finite-product preserving presheaves satisfying the equalizer condition on `CompHaus`/`Profinite`, and just finite-product preserving presheaves on `Stonean`.

Co-authored-by: Riccardo Brasca @riccardobrasca [riccardo.brasca@gmail.com](mailto:riccardo.brasca@gmail.com)
Co-authored-by: Filippo A E Nuccio @faenuccio [filippo.nuccio@univ-st-etienne.fr](mailto:filippo.nuccio@univ-st-etienne.fr)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 4, 2023

Build failed (retrying...):

@eric-wieser
Copy link
Member

bors r-

I'm pretty sure this is the one breaking the bors batches; could you merge master and fix the issues?

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 4, 2023

Canceled.

@dagurtomas
Copy link
Collaborator Author

Hopefully works now. There were some name changes since this was last updated.

@riccardobrasca
Copy link
Member

It seems it does, thanks! (And congratulation for this result!)

bors merge

mathlib-bors bot pushed a commit that referenced this pull request Dec 5, 2023
@dagurtomas
feat(Condensed): Explicit descriptions of condensed sets (#6731)
c5eb45f 
We prove the characterisation of condensed sets as finite-product preserving presheaves satisfying the equalizer condition on `CompHaus`/`Profinite`, and just finite-product preserving presheaves on `Stonean`.

Co-authored-by: Riccardo Brasca @riccardobrasca [riccardo.brasca@gmail.com](mailto:riccardo.brasca@gmail.com)
Co-authored-by: Filippo A E Nuccio @faenuccio [filippo.nuccio@univ-st-etienne.fr](mailto:filippo.nuccio@univ-st-etienne.fr)
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Dec 5, 2023

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(Condensed): Explicit descriptions of condensed sets [Merged by Bors] - feat(Condensed): Explicit descriptions of condensed sets Dec 5, 2023
@mathlib-bors mathlib-bors bot closed this Dec 5, 2023
@mathlib-bors mathlib-bors bot deleted the dagur_explicit_condensed branch December 5, 2023 09:06
awueth pushed a commit that referenced this pull request Dec 19, 2023
@dagurtomas @awueth
feat(Condensed): Explicit descriptions of condensed sets (#6731)
7743d5c 
We prove the characterisation of condensed sets as finite-product preserving presheaves satisfying the equalizer condition on `CompHaus`/`Profinite`, and just finite-product preserving presheaves on `Stonean`.

Co-authored-by: Riccardo Brasca @riccardobrasca [riccardo.brasca@gmail.com](mailto:riccardo.brasca@gmail.com)
Co-authored-by: Filippo A E Nuccio @faenuccio [filippo.nuccio@univ-st-etienne.fr](mailto:filippo.nuccio@univ-st-etienne.fr)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory t-condensed Condensed mathematics t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
Toward solid abelian groups
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dagurtomas @leanprover-community-mathlib4-bot @eric-wieser @riccardobrasca @jcommelin @digama0