Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - [Merged by Bors] - feat: condensed sets are equivalent to sheaves on Stonean and Profinite #6810

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - [Merged by Bors] - feat: condensed sets are equivalent to sheaves on Stonean and Profinite #6810

wants to merge 6 commits into from

Conversation

dagurtomas
Copy link
Collaborator

@dagurtomas dagurtomas commented Aug 27, 2023 •
edited by github-actions bot
Loading

Co-authored-by: Adam Topaz @adamtopaz
Co-authored-by: Nick Kuhn @nick-kuhn

Open in Gitpod

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the blocked-by-other-PR This PR depends on another PR to Mathlib label Aug 27, 2023
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the blocked-by-other-PR This PR depends on another PR to Mathlib label Sep 6, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

This PR/issue depends on:

@ADedecker
Copy link
Member

Is this ready for review?

@bors bors bot changed the base branch from master to ScottCarnahan/BinomialRing2 September 17, 2023 03:26
@semorrison semorrison changed the base branch from ScottCarnahan/BinomialRing2 to master September 17, 2023 12:11
@dagurtomas dagurtomas added awaiting-review t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters labels Sep 28, 2023
adamtopaz
adamtopaz requested changes Oct 2, 2023
View reviewed changes
Mathlib/Condensed/Equivalence.lean Outdated Show resolved Hide resolved
Mathlib/Condensed/Equivalence.lean
· cases hypo1
exact ⟨⟨presentation B, h, presentation.π B, hf⟩⟩

theorem coverDense.inducedTopology_Sieve_iff_EffectiveEpiFamily (X : Stonean) (S : Sieve X) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this really needed? I had the impression that we now had this for the coherent topology on any precoherent category.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this lemma together with coherentTopology.mem_sieves_iff_hasEffectiveEpiFamily that you mentioned shows that the induced topology coincides with the coherent topology.

jcommelin
jcommelin approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Oct 20, 2023
bors bot pushed a commit that referenced this pull request Oct 20, 2023
@dagurtomas
feat: condensed sets are equivalent to sheaves on Stonean and `Prof…
93521b7 
…inite` (#6810)

Co-authored-by: Adam Topaz @adamtopaz 
Co-authored-by: Nick Kuhn @nick-kuhn 

- [x] depends on: #6809
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: condensed sets are equivalent to sheaves on Stonean and Profinite [Merged by Bors] - feat: condensed sets are equivalent to sheaves on Stonean and Profinite Oct 20, 2023
@bors bors bot closed this Oct 20, 2023
@bors
Copy link

bors bot commented Oct 20, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title [Merged by Bors] - feat: condensed sets are equivalent to sheaves on Stonean and Profinite [Merged by Bors] - [Merged by Bors] - feat: condensed sets are equivalent to sheaves on Stonean and Profinite Oct 20, 2023
@dagurtomas dagurtomas mentioned this pull request Nov 3, 2023
Closed
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdOne erdOne erdOne left review comments

@github-actions github-actions[bot] github-actions left review comments

@adamtopaz adamtopaz adamtopaz requested changes

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-category-theory Category theory t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
Toward solid abelian groups
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dagurtomas @leanprover-community-mathlib4-bot @ADedecker @adamtopaz @jcommelin @erdOne