Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat: Lemmas about integrals of bounded continuous functions. #7222

Closed

Conversation

kkytola
Copy link
Collaborator

@kkytola kkytola commented Sep 17, 2023

This PR adds some lemmas about integrals of bounded continuous functions. The lemmas are collected in a separate file.


Existing lemmas about integrals of bounded continuous functions, especially from MeasureTheory.Measure.FiniteMeasure, are moved to the new file specifically devoted to this purpose.

The use case for the newly added lemmas is the proof of the last implication of portmanteau theorem.

Open in Gitpod

@kkytola kkytola added WIP Work in progress t-measure-probability Measure theory / Probability theory labels Sep 17, 2023
@kkytola kkytola added awaiting-review and removed WIP Work in progress labels Sep 18, 2023
Copy link
Contributor

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!


variable {X : Type*} [MeasurableSpace X] [TopologicalSpace X] [OpensMeasurableSpace X]

theorem NNReal.coe_ennreal_comp_measurable (f : X →ᵇ ℝ≥0) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are in the BoundedContinuousFunction namespace, and you would like this kind of lemma to be accessible by dot notation, so making it long by prefixing it with NNReal is probably not a good pick. I would just call it measurable_coe_ennreal_comp as there is no ambiguity here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I thought that a sub-namespace would be clearer for organization, but I realize that it actually breaks the dot notation.

I wonder, however, if it can become a problem to state many lemmas that are specific to the case of NNReal codomain in the BoundedContinuousFunction namespace. I believe there are good use cases for those specific lemmas in the topology of weak convergence and in the Riesz-Markov-Kakutani representation theorem. But I mildly worry about littering the namespace with such particular cases... I assume that the ..._of_... is the best existing naming convention for specifying the codomain. So for now, essentially in line with your other suggestions, I will add something like ...of_nnreal... to the names (and remove the attempted sub-namespace), except in cases which otherwise are unambiguous like this exact one.

@bors
Copy link

bors bot commented Sep 26, 2023

✌️ kkytola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@kkytola
Copy link
Collaborator Author

kkytola commented Sep 27, 2023

✌️ kkytola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+

bors bot pushed a commit that referenced this pull request Sep 27, 2023
This PR adds some lemmas about integrals of bounded continuous functions. The lemmas are collected in a separate file.



Co-authored-by: kkytola <39528102+kkytola@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 27, 2023

Build failed:

@kkytola
Copy link
Collaborator Author

kkytola commented Sep 27, 2023

✌️ kkytola can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

bors r+

bors r+

bors bot pushed a commit that referenced this pull request Sep 27, 2023
This PR adds some lemmas about integrals of bounded continuous functions. The lemmas are collected in a separate file.



Co-authored-by: kkytola <39528102+kkytola@users.noreply.github.com>
@bors
Copy link

bors bot commented Sep 28, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title feat: Lemmas about integrals of bounded continuous functions. [Merged by Bors] - feat: Lemmas about integrals of bounded continuous functions. Sep 28, 2023
@bors bors bot closed this Sep 28, 2023
@bors bors bot deleted the kkytola/integrals_of_bounded_continuous_functions branch September 28, 2023 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated t-measure-probability Measure theory / Probability theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants