Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(Topology/Homeomorph): rename type variables #7587

Closed
wants to merge 13 commits into from
Closed

[Merged by Bors] - chore(Topology/Homeomorph): rename type variables #7587

wants to merge 13 commits into from

Conversation

grunweg
Copy link
Collaborator

@grunweg grunweg commented Oct 9, 2023 •
edited
Loading

X, Y, Z are standard mathematical names for topological spaces.
As discussed on zulip, let us rename them.

@grunweg grunweg added awaiting-review t-topology Topological spaces, uniform spaces, metric spaces, filters labels Oct 9, 2023
@grunweg grunweg changed the title chore (Topology/Homeomorph): rename type variables chore(Topology/Homeomorph): rename type variables Oct 9, 2023
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 9, 2023

I don't quite understand the build errors and have asked on Zulip. Help welcome!

@grunweg grunweg added the help-wanted The author needs attention to resolve issues label Oct 9, 2023
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 9, 2023

Found a fix, I think.

@grunweg grunweg removed the help-wanted The author needs attention to resolve issues label Oct 9, 2023
@grunweg grunweg mentioned this pull request Oct 9, 2023
Closed
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 9, 2023
alreadydone
alreadydone approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
alreadydone
alreadydone approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

alreadydone
alreadydone reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@alreadydone alreadydone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I saw the problems found by @eric-wieser in the other PR, so I took a closer look. Fortunately, there aren't much that could go wrong in this file ...

Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 10, 2023

Thank you for the fast review. I have addressed all comments (and also renamed an equivalence a to h twice).

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. label Oct 10, 2023
@grunweg
Copy link
Collaborator Author

grunweg commented Oct 10, 2023

I'm puzzled by the build failures; I don't know enough to fix them. Help appreciated.

@grunweg grunweg added the help-wanted The author needs attention to resolve issues label Oct 10, 2023
alreadydone
alreadydone reviewed Oct 10, 2023
View reviewed changes
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
Mathlib/Topology/Homeomorph.lean Outdated Show resolved Hide resolved
@alreadydone alreadydone added awaiting-CI and removed help-wanted The author needs attention to resolve issues awaiting-review labels Oct 10, 2023
@alreadydone
Copy link
Contributor

maintainer merge

@github-actions
Copy link

🚀 Pull request has been placed on the maintainer queue by alreadydone.

jcommelin
jcommelin approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the ready-to-merge This PR has been sent to bors. label Oct 10, 2023
bors bot pushed a commit that referenced this pull request Oct 10, 2023
@grunweg @alreadydone
chore(Topology/Homeomorph): rename type variables (#7587)
4a20c4e 
X, Y, Z are standard mathematical names for topological spaces.
As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, let us rename them.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@bors
Copy link

bors bot commented Oct 10, 2023

Canceled.

@grunweg
Copy link
Collaborator Author

grunweg commented Oct 10, 2023 •
edited
Loading

@jcommelin I've merged master (to adapt the changes in #7595 as well). Can you approve again, please?

@alreadydone alreadydone added awaiting-CI and removed ready-to-merge This PR has been sent to bors. awaiting-CI labels Oct 10, 2023
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added the ready-to-merge This PR has been sent to bors. label Oct 11, 2023
bors bot pushed a commit that referenced this pull request Oct 11, 2023
@grunweg @alreadydone
chore(Topology/Homeomorph): rename type variables (#7587)
b39fc2a 
X, Y, Z are standard mathematical names for topological spaces.
As [discussed](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/Naming.20convention.3A.20topological.20spaces/near/395769893) on zulip, let us rename them.

Co-authored-by: Junyan Xu <junyanxu.math@gmail.com>
@bors
Copy link

bors bot commented Oct 11, 2023

Pull request successfully merged into master.

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot changed the title chore(Topology/Homeomorph): rename type variables [Merged by Bors] - chore(Topology/Homeomorph): rename type variables Oct 11, 2023
@bors bors bot closed this Oct 11, 2023
@bors bors bot deleted the MR-rename-types4a branch October 11, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alreadydone alreadydone alreadydone approved these changes

@adomani adomani adomani left review comments

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has been sent to bors. t-topology Topological spaces, uniform spaces, metric spaces, filters
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grunweg @alreadydone @jcommelin @adomani @leanprover-community-mathlib4-bot