chore: changes to adapt to leanprover/lean4#2644 #7606
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Oct 13, 2023
Mathlib/Algebra/Category/GroupCat/EquivalenceGroupAddGroup.lean
Outdated
Show resolved
Hide resolved
mattrobball
reviewed
Oct 14, 2023
| @@ -34,7 +34,8 @@ def monoidalClosedHomEquiv (M N P : ModuleCat.{u} R) : | |||
| left_inv f := by | |||
| apply TensorProduct.ext' | |||
| intro m n | |||
| rw [coe_comp, Function.comp_apply, MonoidalCategory.braiding_hom_apply, | |||
| -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644 | |||
| erw [coe_comp, Function.comp_apply, MonoidalCategory.braiding_hom_apply, | |||
There was a problem hiding this comment.
There is some strange behavior here. If I break out the terms that need erw then the following closes the goal alone
erw [coe_comp]
rw [Function.comp_apply]
erw [MonoidalCategory.braiding_hom_apply, TensorProduct.lift.tmul]
mattrobball
reviewed
Oct 14, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
…y/mathlib4 into lean-pr-testing-2644
eric-wieser
reviewed
Oct 15, 2023
Comment on lines
78
to
80
| -- This lemma has always been bad, but lean4#2644 made `simp` start noticing | ||
| @[simp, nolint simpNF] | ||
| theorem ε_apply (r : R) : ε R r = Finsupp.single PUnit.unit r := |
There was a problem hiding this comment.
If ε is an implementation detail, then presumably we can use local simp here?
There was a problem hiding this comment.
Feel free to make such changes yourself, but otherwise I'm going to leave these for "later".
semorrison
commented
Oct 15, 2023
Comment on lines
-118
to
-128
| namespace NameSet | ||
|
|
||
| /-- The union of two `NameSet`s. -/ | ||
| def append (s t : NameSet) : NameSet := | ||
| s.mergeBy (fun _ _ _ => .unit) t | ||
|
|
||
| instance : Append NameSet where | ||
| append := NameSet.append | ||
|
|
||
| end NameSet | ||
|
|
There was a problem hiding this comment.
You can ignore the changes to this file. They are needed here to get Mathlib to compile against this toolchain, but do not need to be reviewed.
eric-wieser
reviewed
Oct 16, 2023
eric-wieser
reviewed
Oct 16, 2023
eric-wieser
reviewed
Oct 16, 2023
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
Closing in favour of the actual bump PR, #7703 |
bors bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
This includes all the changes from #7606. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
leanprover-community-mathlib4-bot
added
the
merge-conflict
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
leanprover/lean4#2644