Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changes to adapt to leanprover/lean4#2644 #7606

Closed
wants to merge 499 commits into from
Closed
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
499 commits
Select commit Hold shift + click to select a range
e8db259
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 19, 2023
cd97f2e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 19, 2023
f02fdbf
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 19, 2023
19805f6
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 19, 2023
ef0e7c1
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 19, 2023
eafc575
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
2f03cc8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
17a4465
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
10edb20
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
fdd6434
chore: bump to nightly-2023-09-20
leanprover-community-mathlib4-bot Sep 20, 2023
488b427
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
5f8dfc3
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
4048ff9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
64af06e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
7aff542
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
450d567
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 20, 2023
da34301
Trigger CI for https://github.com/leanprover/lean4/pull/2502
leanprover-community-mathlib4-bot Sep 20, 2023
7a80ae7
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
f3cdca8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
fcc8232
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
92542a8
chore: bump to nightly-2023-09-21
leanprover-community-mathlib4-bot Sep 21, 2023
5e79e76
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
6bbc802
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
73e8d32
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
26d7ca2
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
363e810
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
f3f41ea
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
b534ed4
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
0ad2194
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
105030f
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
0c87732
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
02e4bee
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 21, 2023
121ae13
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
46cd885
merge
semorrison Sep 22, 2023
3043876
Merge branch 'nightly-testing' of github.com:leanprover-community/mat…
semorrison Sep 22, 2023
35d45df
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
d823d83
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
6e44d98
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
b3c2a59
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
659605e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
aca6bf5
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
a56cd1f
chore: bump to nightly-2023-09-22
leanprover-community-mathlib4-bot Sep 22, 2023
caa1b98
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
151bf91
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
c19fb6a
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
087eb61
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
57be952
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
87b0303
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 22, 2023
98c132a
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 23, 2023
9c0f022
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 23, 2023
1efa4bb
chore: bump to nightly-2023-09-23
leanprover-community-mathlib4-bot Sep 23, 2023
8352a04
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 23, 2023
fe44ffb
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
0d1a58e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
8262ccb
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
ee03a68
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
a5c27ad
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
6b3a65b
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
a477df9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
0a07e84
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
c4bc5ee
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 24, 2023
f0b5dae
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 25, 2023
0c3215e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 25, 2023
d3760a1
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 25, 2023
5beacf7
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 25, 2023
3665a74
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 25, 2023
6278b14
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 25, 2023
7f30787
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
f9dc45b
chore: bump to nightly-2023-09-26
leanprover-community-mathlib4-bot Sep 26, 2023
83ced17
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
794aae9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
52747e6
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
6d9eb92
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
3c707e7
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
62b963e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
6185e0c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 26, 2023
8914f4b
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
5a79c9c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
815f5bd
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
11d7489
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
135efb2
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
0d10fe3
chore: bump to nightly-2023-09-27
leanprover-community-mathlib4-bot Sep 27, 2023
49d4d99
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
d555c7f
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
333de50
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
6d33e0c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
90bd5df
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
7b24469
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 27, 2023
cc52df8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
73e3896
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
cdc40bc
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
60b6532
chore: bump to nightly-2023-09-28
leanprover-community-mathlib4-bot Sep 28, 2023
64d04c7
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
ce20f2d
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
c9d73cc
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
4ff1b1f
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
0015bc2
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
cec4a39
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 28, 2023
f5c91dd
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
351d3ed
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
cbe1a8d
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
f9bafbe
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
4895ca1
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
fd61c53
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
82f7788
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
ef42224
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
a419b72
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
466c100
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 29, 2023
ee39108
Merge master into nightly-testing
leanprover-community-mathlib4-bot Sep 30, 2023
d030098
chore: bump to nightly-2023-10-01
leanprover-community-mathlib4-bot Oct 1, 2023
3dd6cef
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 1, 2023
c411c7c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
ec286d5
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
4118518
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
320dd25
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
e6d2325
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
1139f8d
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
6deb700
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
6bbc345
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 2, 2023
ef071fd
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
3f9d324
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
4b76ea4
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
5f86892
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
247e3c0
chore: bump to nightly-2023-10-03
leanprover-community-mathlib4-bot Oct 3, 2023
cd52362
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
bb61fc9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
da7d4a9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
2c3b2d9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
a19f0b8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 3, 2023
587136a
chore: bump to nightly-2023-10-04
leanprover-community-mathlib4-bot Oct 4, 2023
f063bb0
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 4, 2023
52b4e81
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 4, 2023
431e30e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 4, 2023
f3b3f78
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 4, 2023
bc7de07
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 4, 2023
3546e57
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 4, 2023
251fbc1
chore: disable CI cache check for lean-pr-testing-NNNN branches
semorrison Oct 4, 2023
baf157b
Merge branch 'disable-cache-check-for-pr-testing-branches' into night…
semorrison Oct 4, 2023
41a757c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
f55b9b8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
0b59010
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
5d3ecd8
chore: bump to nightly-2023-10-05
leanprover-community-mathlib4-bot Oct 5, 2023
969003a
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
c94fd23
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
7e85b50
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
87a3fd4
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
ca3520b
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
b353b78
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
8725699
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
983e8bb
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
016a010
feat: first isomorphism theorem for rings
PatrickMassot Oct 5, 2023
65b0898
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
c270770
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 5, 2023
70df9a8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 6, 2023
2368315
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 6, 2023
b8ed113
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 6, 2023
5e1c56f
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 6, 2023
7ecc5c8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 6, 2023
24b521a
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 7, 2023
cb06212
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 7, 2023
9114ef9
chore: bump to nightly-2023-10-07
leanprover-community-mathlib4-bot Oct 7, 2023
3c4d859
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 7, 2023
cb64e48
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 7, 2023
8bace51
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 7, 2023
8b8cd5c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 7, 2023
29a2150
chore: bump to nightly-2023-10-08
leanprover-community-mathlib4-bot Oct 8, 2023
f3ec698
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 8, 2023
68dfbe2
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 8, 2023
81f92b1
merge?
semorrison Oct 9, 2023
cde9169
Revert "feat: first isomorphism theorem for rings"
semorrison Oct 9, 2023
ef0c457
re-sync with master after a force push to master
semorrison Oct 9, 2023
ff08040
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
b3a43a1
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
a7908e9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
dafe0a8
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
e4b43a3
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
aaf2bdd
chore: bump to nightly-2023-10-09
leanprover-community-mathlib4-bot Oct 9, 2023
defdd7b
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
19bb0e5
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
bcc268d
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
96999df
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
04f3972
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
6ccfb14
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
02fb575
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
541b07b
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
2565d25
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 9, 2023
6825846
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 10, 2023
2994c98
start fresh
semorrison Oct 10, 2023
ad25ba0
regressions
semorrison Oct 10, 2023
24f8157
chore: bump to nightly-2023-10-10
leanprover-community-mathlib4-bot Oct 10, 2023
31bbb2b
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 10, 2023
fe477aa
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 10, 2023
03e0eb0
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 10, 2023
5a1da91
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 10, 2023
7f5c163
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 10, 2023
322700f
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
c467659
Trigger CI for https://github.com/leanprover/lean4/pull/2644
leanprover-community-mathlib4-bot Oct 11, 2023
34926f5
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
9081f93
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
7e3af34
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
031ff47
chore: bump to nightly-2023-10-11
leanprover-community-mathlib4-bot Oct 11, 2023
85684b2
fixes
semorrison Oct 11, 2023
4174794
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
4f9ad48
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
2b62029
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
1cb772e
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
412c3fe
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
c7e612c
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
9bb8b57
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 11, 2023
6e6e777
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
c05c82f
fix
mattrobball Oct 12, 2023
9b84ecf
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
08ab8e2
lint
mattrobball Oct 12, 2023
db18a31
clean up
mattrobball Oct 12, 2023
602fa7f
counterex
mattrobball Oct 12, 2023
478576c
archive
mattrobball Oct 12, 2023
57a8120
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
a491559
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
187563b
chore: bump to nightly-2023-10-12
leanprover-community-mathlib4-bot Oct 12, 2023
c649ca9
use patched aesop
semorrison Oct 12, 2023
a5befd2
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
3f8fa4d
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
a725cd9
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
dc22ac5
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
b758e1d
Merge master into nightly-testing
leanprover-community-mathlib4-bot Oct 12, 2023
5293a8e
merge
semorrison Oct 12, 2023
0bd81a1
Flag modifications dure to leanprover/lean4#2644
PatrickMassot Oct 13, 2023
47e0ed2
reviewdog whitespace fixes
semorrison Oct 13, 2023
062fbd7
Update Mathlib/Algebra/Algebra/Subalgebra/Basic.lean
semorrison Oct 13, 2023
1d59d17
remove another no-op simpNF
eric-wieser Oct 13, 2023
1ba14a7
simps hack
eric-wieser Oct 13, 2023
a77c332
add a simpNF comment
eric-wieser Oct 13, 2023
6f28a6c
Revert "simps hack"
mattrobball Oct 13, 2023
99e242b
review comments
mattrobball Oct 13, 2023
942f999
whitespace
mattrobball Oct 13, 2023
bd32f9a
review comments + epsilon
mattrobball Oct 13, 2023
d90aa6a
more clean up
mattrobball Oct 13, 2023
1c87c93
clean up some more
mattrobball Oct 14, 2023
5fbda93
fix long line
semorrison Oct 14, 2023
b3dba86
Update Mathlib/Algebra/Category/GroupCat/Biproducts.lean
semorrison Oct 15, 2023
13a103f
Update Mathlib/Algebra/Category/GroupCat/Biproducts.lean
semorrison Oct 15, 2023
5c02767
comments
semorrison Oct 15, 2023
4a2d306
Merge branch 'lean-pr-testing-2644' of github.com:leanprover-communit…
semorrison Oct 15, 2023
4afb4ea
comments
semorrison Oct 15, 2023
dbb1436
fix comments
semorrison Oct 15, 2023
73f0566
fixes
semorrison Oct 15, 2023
35cdd1c
fixes
semorrison Oct 15, 2023
ffa5702
more
semorrison Oct 15, 2023
740abe2
Update Mathlib/Order/InitialSeg.lean
semorrison Oct 16, 2023
11ef6da
suggestions from review
semorrison Oct 16, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Archive/Sensitivity.lean
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ theorem duality (p q : Q n) : ε p (e q) = if p = q then 1 else 0 := by
· rw [show p = q from Subsingleton.elim (α := Q 0) p q]
dsimp [ε, e]
simp
rfl
· dsimp [ε, e]
cases hp : p 0 <;> cases hq : q 0
all_goals
Expand Down
3 changes: 2 additions & 1 deletion Counterexamples/DirectSumIsInternal.lean
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ theorem withSign.not_injective :
-- porting note: `DFinsupp.singleAddHom_apply` doesn't work so we have to unfold
dsimp [DirectSum.lof_eq_of, DirectSum.of, DFinsupp.singleAddHom] at h
replace h := FunLike.congr_fun h 1
rw [DFinsupp.zero_apply, DFinsupp.add_apply, DFinsupp.single_eq_same,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [DFinsupp.zero_apply, DFinsupp.add_apply, DFinsupp.single_eq_same,
DFinsupp.single_eq_of_ne UnitsInt.one_ne_neg_one.symm, add_zero, Subtype.ext_iff,
Submodule.coe_zero] at h
apply zero_ne_one h.symm
Expand Down
6 changes: 4 additions & 2 deletions Counterexamples/Pseudoelement.lean
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,15 @@ theorem x_not_pseudo_eq : ¬PseudoEqual _ x y := by
Preadditive.comp_add] at ha
let π₁ := (biprod.fst : of ℤ ℚ ⊞ of ℤ ℚ ⟶ _)
have ha₁ := congr_arg π₁ ha
rw [← CategoryTheory.comp_apply, ← CategoryTheory.comp_apply] at ha₁
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
semorrison marked this conversation as resolved.
Show resolved Hide resolved
erw [← CategoryTheory.comp_apply, ← CategoryTheory.comp_apply] at ha₁
simp only [BinaryBiproduct.bicone_fst, biprod.lift_fst, CategoryTheory.id_apply,
biprod.lift_fst_assoc, Category.id_comp, biprod.lift_snd_assoc, Linear.smul_comp,
Preadditive.add_comp, BinaryBicone.inl_fst, BinaryBicone.inr_fst, smul_zero, add_zero] at ha₁
let π₂ := (biprod.snd : of ℤ ℚ ⊞ of ℤ ℚ ⟶ _)
have ha₂ := congr_arg π₂ ha
rw [← CategoryTheory.comp_apply, ← CategoryTheory.comp_apply] at ha₂
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [← CategoryTheory.comp_apply, ← CategoryTheory.comp_apply] at ha₂
simp only [BinaryBiproduct.bicone_snd, biprod.lift_snd, CategoryTheory.id_apply,
biprod.lift_fst_assoc, Category.id_comp, biprod.lift_snd_assoc, Linear.smul_comp,
Preadditive.add_comp, BinaryBicone.inl_snd, BinaryBicone.inr_snd, zero_add, two_smul] at ha₂
Expand Down
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Algebra/Subalgebra/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -741,7 +741,7 @@ noncomputable def ofInjectiveField {E F : Type*} [DivisionRing E] [Semiring F] [

/-- Given an equivalence `e : A ≃ₐ[R] B` of `R`-algebras and a subalgebra `S` of `A`,
`subalgebra_map` is the induced equivalence between `S` and `S.map e` -/
@[simps!]
@[simps!, nolint simpNF]
eric-wieser marked this conversation as resolved.
Show resolved Hide resolved
def subalgebraMap (e : A ≃ₐ[R] B) (S : Subalgebra R A) : S ≃ₐ[R] S.map e.toAlgHom :=
{ e.toRingEquiv.subsemiringMap S.toSubsemiring with
commutes' := fun r => by
Expand Down Expand Up @@ -1509,4 +1509,5 @@ theorem mem_subalgebraOfSubring {x : R} {S : Subring R} : x ∈ subalgebraOfSubr
Iff.rfl
#align mem_subalgebra_of_subring mem_subalgebraOfSubring

attribute [nolint simpNF] AlgEquiv.subalgebraMap_apply_coe AlgEquiv.subalgebraMap_symm_apply_coe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not at all clear to me why these lemmas are problematic; is their statement changing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, simp has changed!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, some of these lemmas are generated by running simp and looking at the output; so the two aren't mutually exclusive.

end Int
6 changes: 4 additions & 2 deletions Mathlib/Algebra/Category/AlgebraCat/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -207,12 +207,14 @@ def toAlgEquiv {X Y : AlgebraCat R} (i : X ≅ Y) : X ≃ₐ[R] Y where
-- porting note: was `by tidy`
change (i.hom ≫ i.inv) x = x
simp only [hom_inv_id]
rw [id_apply]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [id_apply]
right_inv x := by
-- porting note: was `by tidy`
change (i.inv ≫ i.hom) x = x
simp only [inv_hom_id]
rw [id_apply]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [id_apply]
map_add' := i.hom.map_add -- Porting note: was `by tidy`
map_mul' := i.hom.map_mul -- Porting note: was `by tidy`
commutes' := i.hom.commutes -- Porting note: was `by tidy`
Expand Down
14 changes: 14 additions & 0 deletions Mathlib/Algebra/Category/AlgebraCat/Limits.lean
Original file line number Diff line number Diff line change
Expand Up @@ -105,16 +105,30 @@ def limitConeIsLimit (F : J ⥤ AlgebraCatMax.{v, w} R) : IsLimit (limitCone.{v,
apply Subtype.ext
ext j
simp [forget_map_eq_coe, AlgHom.map_one, Functor.mapCone_π_app]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [map_one]
semorrison marked this conversation as resolved.
Show resolved Hide resolved
rfl
· intro x y
apply Subtype.ext
ext j
simp [forget_map_eq_coe, AlgHom.map_mul, Functor.mapCone_π_app]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [map_mul]
rfl
· simp [forget_map_eq_coe, AlgHom.map_zero, Functor.mapCone_π_app]
-- The above `simp` was enough before leanprover/lean4#2644
apply Subtype.ext
dsimp
funext u
erw [map_zero]
rfl
· intro x y
simp [forget_map_eq_coe, AlgHom.map_add, Functor.mapCone_π_app]
-- The above `simp` was enough before leanprover/lean4#2644
apply Subtype.ext
dsimp
funext u
erw [map_add]
rfl
· intro r
apply Subtype.ext
Expand Down
8 changes: 5 additions & 3 deletions Mathlib/Algebra/Category/GroupCat/Adjunctions.lean
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ theorem free_obj_coe {α : Type u} : (free.obj α : Type u) = FreeAbelianGroup
rfl
#align AddCommGroup.free_obj_coe AddCommGroupCat.free_obj_coe

@[simp]
@[simp, nolint simpNF]
semorrison marked this conversation as resolved.
Show resolved Hide resolved
theorem free_map_coe {α β : Type u} {f : α → β} (x : FreeAbelianGroup α) :
(free.map f) x = f <$> x :=
rfl
Expand Down Expand Up @@ -102,9 +102,11 @@ def free : Type u ⥤ GroupCat where
obj α := of (FreeGroup α)
map := FreeGroup.map
map_id := by
intros; ext1; rw [←FreeGroup.map.unique]; intros; rfl
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
intros; ext1; erw [←FreeGroup.map.unique] <;> intros <;> rfl
map_comp := by
intros; ext1; rw [←FreeGroup.map.unique]; intros; rfl
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
intros; ext1; erw [←FreeGroup.map.unique] <;> intros <;> rfl
#align Group.free GroupCat.free

/-- The free-forgetful adjunction for groups.
Expand Down
4 changes: 3 additions & 1 deletion Mathlib/Algebra/Category/GroupCat/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ set_option linter.uppercaseLean3 false in
#align AddGroup.zero_apply AddGroupCat.zero_apply

/-- Typecheck a `MonoidHom` as a morphism in `GroupCat`. -/
@[to_additive]
@[to_additive, nolint simpNF]
def ofHom {X Y : Type u} [Group X] [Group Y] (f : X →* Y) : of X ⟶ of Y :=
f
set_option linter.uppercaseLean3 false in
Expand Down Expand Up @@ -528,3 +528,5 @@ abbrev CommGroupCatMax.{u1, u2} := CommGroupCat.{max u1 u2}
/-- An alias for `AddCommGroupCat.{max u v}`, to deal around unification issues. -/
@[nolint checkUnivs]
abbrev AddCommGroupCatMax.{u1, u2} := AddCommGroupCat.{max u1 u2}

attribute [nolint simpNF] AddGroupCat.ofHom_apply GroupCat.ofHom_apply
semorrison marked this conversation as resolved.
Show resolved Hide resolved
2 changes: 2 additions & 0 deletions Mathlib/Algebra/Category/GroupCat/Biproducts.lean
Original file line number Diff line number Diff line change
Expand Up @@ -144,4 +144,6 @@ theorem biproductIsoPi_inv_comp_π (f : J → AddCommGroupCat.{u}) (j : J) :
IsLimit.conePointUniqueUpToIso_inv_comp _ _ (Discrete.mk j)
#align AddCommGroup.biproduct_iso_pi_inv_comp_π AddCommGroupCat.biproductIsoPi_inv_comp_π

attribute [nolint simpNF] AddCommGroupCat.biprodIsoProd_hom_apply
AddCommGroupCat.biproductIsoPi_hom_apply
semorrison marked this conversation as resolved.
Show resolved Hide resolved
end AddCommGroupCat
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,12 @@ def commGroupAddCommGroupEquivalence : CommGroupCat ≌ AddCommGroupCat :=
(NatIso.ofComponents fun X => MulEquiv.toCommGroupCatIso (MulEquiv.multiplicativeAdditive X))
(NatIso.ofComponents fun X => AddEquiv.toAddCommGroupCatIso (AddEquiv.additiveMultiplicative X))
#align CommGroup_AddCommGroup_equivalence commGroupAddCommGroupEquivalence

attribute [nolint simpNF] groupAddGroupEquivalence_unitIso_hom_app_apply
groupAddGroupEquivalence_counitIso_inv_app_apply
groupAddGroupEquivalence_unitIso_inv_app_apply
groupAddGroupEquivalence_counitIso_hom_app_apply
commGroupAddCommGroupEquivalence_counitIso_hom_app_apply
commGroupAddCommGroupEquivalence_unitIso_inv_app_apply
commGroupAddCommGroupEquivalence_unitIso_hom_app_apply
commGroupAddCommGroupEquivalence_counitIso_inv_app_apply
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Category/GroupCat/Injective.lean
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,8 @@ variable {a}

lemma eq_zero_of_toRatCircle_apply_self
(h : toRatCircle ⟨a, Submodule.mem_span_singleton_self a⟩ = 0) : a = 0 := by
rw [toRatCircle, LinearMap.comp_apply, LinearEquiv.coe_toLinearMap,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [toRatCircle, LinearMap.comp_apply, LinearEquiv.coe_toLinearMap,
equivZModSpanAddOrderOf_apply_self, Submodule.liftQSpanSingleton_apply,
LinearMap.toSpanSingleton_one, AddCircle.coe_eq_zero_iff] at h
obtain ⟨n, hn⟩ := h
Expand Down
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Category/GroupCat/Limits.lean
Original file line number Diff line number Diff line change
Expand Up @@ -464,5 +464,6 @@ def kernelIsoKerOver {G H : AddCommGroupCat.{u}} (f : G ⟶ H) :
Over.isoMk (kernelIsoKer f)
set_option linter.uppercaseLean3 false in
#align AddCommGroup.kernel_iso_ker_over AddCommGroupCat.kernelIsoKerOver

attribute [nolint simpNF] AddCommGroupCat.kernelIsoKerOver_inv_left_apply
AddCommGroupCat.kernelIsoKerOver_hom_left_apply_coe
end AddCommGroupCat
6 changes: 3 additions & 3 deletions Mathlib/Algebra/Category/ModuleCat/Adjunctions.lean
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ theorem μ_natural {X Y X' Y' : Type u} (f : X ⟶ Y) (g : X' ⟶ Y') :
= (Finsupp.mapDomain (f ⊗ g) (finsuppTensorFinsupp' R X X'
(Finsupp.single x 1 ⊗ₜ[R] Finsupp.single x' 1))) _
simp_rw [Finsupp.mapDomain_single, finsuppTensorFinsupp'_single_tmul_single, mul_one,
Finsupp.mapDomain_single, CategoryTheory.tensor_apply]
Finsupp.mapDomain_single, CategoryTheory.tensor_apply]; rfl
#align Module.free.μ_natural ModuleCat.Free.μ_natural

theorem left_unitality (X : Type u) :
Expand Down Expand Up @@ -176,7 +176,7 @@ theorem associativity (X Y Z : Type u) :
(Finsupp.single x 1 ⊗ₜ[R]
finsuppTensorFinsupp' R Y Z (Finsupp.single y 1 ⊗ₜ[R] Finsupp.single z 1)) a
simp_rw [finsuppTensorFinsupp'_single_tmul_single, Finsupp.mapDomain_single, mul_one,
CategoryTheory.associator_hom_apply]
CategoryTheory.associator_hom_apply]; rfl
#align Module.free.associativity ModuleCat.Free.associativity

-- In fact, it's strong monoidal, but we don't yet have a typeclass for that.
Expand Down Expand Up @@ -422,5 +422,5 @@ def liftUnique (F : C ⥤ D) (L : Free R C ⥤ D) [L.Additive] [L.Linear R]
#align category_theory.Free.lift_unique CategoryTheory.Free.liftUnique

end Free

attribute [nolint simpNF] ModuleCat.Free.ε_apply
end CategoryTheory
2 changes: 1 addition & 1 deletion Mathlib/Algebra/Category/ModuleCat/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -470,5 +470,5 @@ lemma forget₂_map_homMk :
(forget₂ (ModuleCat R) AddCommGroupCat).map (homMk φ hφ) = φ := rfl

end

attribute [nolint simpNF] ModuleCat.mkOfSMul_smul
end ModuleCat
1 change: 1 addition & 0 deletions Mathlib/Algebra/Category/ModuleCat/Biproducts.lean
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,5 @@ noncomputable def lequivProdOfLeftSplitExact {f : M →ₗ[R] A} (hg : Function.
biprodIsoProd _ _).toLinearEquiv.symm
#align lequiv_prod_of_left_split_exact lequivProdOfLeftSplitExact

attribute [nolint simpNF] ModuleCat.biprodIsoProd_hom_apply ModuleCat.biproductIsoPi_hom_apply
end SplitExact
13 changes: 9 additions & 4 deletions Mathlib/Algebra/Category/ModuleCat/ChangeOfRings.lean
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,7 @@ variable (M : Type v) [AddCommMonoid M] [Module R M]
-- mathport name: «expr ⊗ₜ[ , ] »
-- This notation is necessary because we need to reason about `s ⊗ₜ m` where `s : S` and `m : M`;
-- without this notation, one need to work with `s : (restrictScalars f).obj ⟨S⟩`.
/-- Tensor multiplication using a ring morphism. -/
mattrobball marked this conversation as resolved.
Show resolved Hide resolved
scoped[ChangeOfRings]
notation s "⊗ₜ[" R "," f "]" m => @TensorProduct.tmul R _ _ _ _ _ (Module.compHom _ f) _ s m

Expand Down Expand Up @@ -743,8 +744,10 @@ def counit : restrictScalars.{max v u₂,u₁,u₂} f ⋙ extendScalars f ⟶
· rw [map_zero, map_zero]
· dsimp
rw [ModuleCat.coe_comp, ModuleCat.coe_comp,Function.comp,Function.comp,
ExtendScalars.map_tmul, restrictScalars.map_apply, Counit.map_apply, Counit.map_apply,
lift.tmul, lift.tmul, LinearMap.coe_mk, LinearMap.coe_mk]
ExtendScalars.map_tmul, restrictScalars.map_apply]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [Counit.map_apply] --Counit.map_apply,
mattrobball marked this conversation as resolved.
Show resolved Hide resolved
rw [lift.tmul, LinearMap.coe_mk, LinearMap.coe_mk]
set s' : S := s'
change s' • g y = g (s' • y)
rw [map_smul]
Expand Down Expand Up @@ -772,7 +775,8 @@ def extendRestrictScalarsAdj {R : Type u₁} {S : Type u₂} [CommRing R] [CommR
letI m2 : Module R Y := Module.compHom Y f
induction' x using TensorProduct.induction_on with s x _ _ _ _
· rw [map_zero, map_zero]
· rw [ExtendRestrictScalarsAdj.homEquiv_symm_apply, ModuleCat.coe_comp, Function.comp_apply,
· -- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [ExtendRestrictScalarsAdj.homEquiv_symm_apply, ModuleCat.coe_comp, Function.comp_apply,
ExtendRestrictScalarsAdj.counit_app, ExtendRestrictScalarsAdj.Counit.map_apply]
dsimp
rw [TensorProduct.lift.tmul]
Expand All @@ -788,5 +792,6 @@ instance {R : Type u₁} {S : Type u₂} [CommRing R] [CommRing S] (f : R →+*
instance {R : Type u₁} {S : Type u₂} [CommRing R] [CommRing S] (f : R →+* S) :
CategoryTheory.IsRightAdjoint (restrictScalars f) :=
⟨_, extendRestrictScalarsAdj f⟩

attribute [nolint simpNF] restrictScalarsId'_inv_apply restrictScalarsId'_hom_apply
restrictScalarsComp'_hom_apply restrictScalarsComp'_inv_apply
end ModuleCat
6 changes: 4 additions & 2 deletions Mathlib/Algebra/Category/ModuleCat/Colimits.lean
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ noncomputable def colimitCocone : Cocone F where
ι :=
{ app := fun j => homMk (colimit.ι (F ⋙ forget₂ _ AddCommGroupCat) j) (fun r => by
dsimp
rw [mkOfSMul_smul]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [mkOfSMul_smul]
simp)
naturality := fun i j f => by
apply (forget₂ _ AddCommGroupCat).map_injective
Expand All @@ -77,7 +78,8 @@ noncomputable def isColimitColimitCocone : IsColimit (colimitCocone F) where
intro j
dsimp
rw [colimit.ι_desc_assoc]
rw [mkOfSMul_smul]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [mkOfSMul_smul]
dsimp
simp only [ι_colimMap_assoc, Functor.comp_obj, forget₂_obj, colimit.ι_desc,
Functor.mapCocone_pt, Functor.mapCocone_ι_app, forget₂_map]
Expand Down
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Category/ModuleCat/Kernels.lean
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,8 @@ def kernelIsLimit : IsLimit (kernelCone f) :=
-- Porting note: broken dot notation on LinearMap.ker
LinearMap.codRestrict (LinearMap.ker f) (Fork.ι s) fun c =>
LinearMap.mem_ker.2 <| by
rw [← @Function.comp_apply _ _ _ f (Fork.ι s) c, ← coe_comp, Fork.condition,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [← @Function.comp_apply _ _ _ f (Fork.ι s) c, ← coe_comp, Fork.condition,
HasZeroMorphisms.comp_zero (Fork.ι s) N]
rfl)
(fun s => LinearMap.subtype_comp_codRestrict _ _ _) fun s m h =>
Expand Down
18 changes: 12 additions & 6 deletions Mathlib/Algebra/Category/ModuleCat/Monoidal/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -277,23 +277,27 @@ instance : MonoidalPreadditive (ModuleCat.{u} R) := by
· dsimp only [autoParam]; intros
refine' TensorProduct.ext (LinearMap.ext fun x => LinearMap.ext fun y => _)
simp only [LinearMap.compr₂_apply, TensorProduct.mk_apply]
rw [LinearMap.zero_apply, MonoidalCategory.hom_apply, LinearMap.zero_apply,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [LinearMap.zero_apply, MonoidalCategory.hom_apply, LinearMap.zero_apply,
TensorProduct.tmul_zero]
· dsimp only [autoParam]; intros
refine' TensorProduct.ext (LinearMap.ext fun x => LinearMap.ext fun y => _)
simp only [LinearMap.compr₂_apply, TensorProduct.mk_apply]
rw [LinearMap.zero_apply, MonoidalCategory.hom_apply, LinearMap.zero_apply,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [LinearMap.zero_apply, MonoidalCategory.hom_apply, LinearMap.zero_apply,
TensorProduct.zero_tmul]
· dsimp only [autoParam]; intros
refine' TensorProduct.ext (LinearMap.ext fun x => LinearMap.ext fun y => _)
simp only [LinearMap.compr₂_apply, TensorProduct.mk_apply]
rw [LinearMap.add_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [LinearMap.add_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply]
erw [MonoidalCategory.hom_apply]
rw [LinearMap.add_apply, TensorProduct.tmul_add]
· dsimp only [autoParam]; intros
refine' TensorProduct.ext (LinearMap.ext fun x => LinearMap.ext fun y => _)
simp only [LinearMap.compr₂_apply, TensorProduct.mk_apply]
rw [LinearMap.add_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [LinearMap.add_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply]
erw [MonoidalCategory.hom_apply]
rw [LinearMap.add_apply, TensorProduct.add_tmul]

Expand All @@ -303,12 +307,14 @@ instance : MonoidalLinear R (ModuleCat.{u} R) := by
· dsimp only [autoParam]; intros
refine' TensorProduct.ext (LinearMap.ext fun x => LinearMap.ext fun y => _)
simp only [LinearMap.compr₂_apply, TensorProduct.mk_apply]
rw [LinearMap.smul_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [LinearMap.smul_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply,
LinearMap.smul_apply, TensorProduct.tmul_smul]
· dsimp only [autoParam]; intros
refine' TensorProduct.ext (LinearMap.ext fun x => LinearMap.ext fun y => _)
simp only [LinearMap.compr₂_apply, TensorProduct.mk_apply]
rw [LinearMap.smul_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [LinearMap.smul_apply, MonoidalCategory.hom_apply, MonoidalCategory.hom_apply,
LinearMap.smul_apply, TensorProduct.smul_tmul, TensorProduct.tmul_smul]

end ModuleCat
4 changes: 3 additions & 1 deletion Mathlib/Algebra/Category/ModuleCat/Monoidal/Closed.lean
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,8 @@ def monoidalClosedHomEquiv (M N P : ModuleCat.{u} R) :
left_inv f := by
apply TensorProduct.ext'
intro m n
rw [coe_comp, Function.comp_apply, MonoidalCategory.braiding_hom_apply,
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [coe_comp, Function.comp_apply, MonoidalCategory.braiding_hom_apply,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some strange behavior here. If I break out the terms that need erw then the following closes the goal alone

    erw [coe_comp]
    rw [Function.comp_apply] 
    erw [MonoidalCategory.braiding_hom_apply, TensorProduct.lift.tmul] 

TensorProduct.lift.tmul, LinearMap.compr₂_apply,
TensorProduct.mk_apply, coe_comp, Function.comp_apply, MonoidalCategory.braiding_hom_apply]
right_inv f := rfl
Expand Down Expand Up @@ -106,4 +107,5 @@ theorem monoidalClosed_pre_app {M N : ModuleCat.{u} R} (P : ModuleCat.{u} R) (f
set_option linter.uppercaseLean3 false in
#align Module.monoidal_closed_pre_app ModuleCat.monoidalClosed_pre_app

attribute [nolint simpNF] ModuleCat.monoidalClosed_curry
mattrobball marked this conversation as resolved.
Show resolved Hide resolved
end ModuleCat
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Category/ModuleCat/Projective.lean
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ instance moduleCat_enoughProjectives : EnoughProjectives (ModuleCat.{max u v} R)
-- Porting note: simp [Finsupp.total_single] fails but rw succeeds
dsimp [Basis.constr]
simp only [Finsupp.lmapDomain_id, comp_id]
rw [Finsupp.total_single, one_smul]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [Finsupp.total_single, one_smul]
rfl ⟩) }⟩
set_option linter.uppercaseLean3 false in
#align Module.Module_enough_projectives ModuleCat.moduleCat_enoughProjectives
Expand Down
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Category/MonCat/Basic.lean
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,8 @@ add_decl_doc addEquivIsoAddCommMonCatIso
instance MonCat.forget_reflects_isos : ReflectsIsomorphisms (forget MonCat.{u}) where
reflects {X Y} f _ := by
let i := asIso ((forget MonCat).map f)
let e : X ≃* Y := MulEquiv.mk i.toEquiv (by aesop)
-- Again a problem that exists already creeps into other things
let e : X ≃* Y := MulEquiv.mk i.toEquiv (MonoidHom.map_mul (show MonoidHom X Y from f))
exact IsIso.of_iso e.toMonCatIso
set_option linter.uppercaseLean3 false in
#align Mon.forget_reflects_isos MonCat.forget_reflects_isos
Expand Down
3 changes: 2 additions & 1 deletion Mathlib/Algebra/Category/MonCat/FilteredColimits.lean
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,8 @@ def colimitDesc (t : Cocone F) : colimit.{v, u} F ⟶ t.pt where
rw [colimit_mul_mk_eq F ⟨i, x⟩ ⟨j, y⟩ (max' i j) (IsFiltered.leftToMax i j)
(IsFiltered.rightToMax i j)]
dsimp [Types.colimitCoconeIsColimit]
rw [MonoidHom.map_mul]
-- This used to be `rw`, but we need `erw` after leanprover/lean4#2644
erw [MonoidHom.map_mul]
-- Porting note : `rw` can't see through coercion is actually forgetful functor,
-- so can't rewrite `t.w_apply`
congr 1 <;>
Expand Down