[Merged by Bors] - feat: long overdue delaborators #7633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickMassot
added
awaiting-review
eric-wieser
reviewed
Oct 12, 2023
| Note that this takes advantage of the fact that `(x : α) → p x` notation is | ||
| never used for propositions, so we can match on this result and rewrite it. -/ | ||
| @[scoped delab forallE] | ||
| def delabPi : Delab := whenPPOption Lean.getPPNotation do | ||
| let stx ← delabForall | ||
| def delabPi' : Delab := whenPPOption Lean.getPPNotation do |
There was a problem hiding this comment.
Why do we have two pi delaborators here?
There was a problem hiding this comment.
Because some people actually like (x : α) → p x instead of Π (x : α), p x so the nice one is scoped.
digama0
reviewed
Oct 13, 2023
|
This looks good to me, modulo a plan to replace this code with something better eventually. There is no need to block on this now if people need these delaborators but I'm sure we can do better. bors r+ |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
This brings to Mathlib assorted delaborators written by @kmill for various projects including Mathematics in Lean. They mostly fix regressions compared to Lean 3. Co-authored-by: Mario Carneiro <mcarneir@andrew.cmu.edu>
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings to Mathlib assorted delaborators written by @kmill for various projects including Mathematics in Lean. They mostly fix regressions compared to Lean 3.