chore (Topology): some universe tweaks #7638
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grunweg
added
awaiting-review
awaiting-CI
t-topology
eric-wieser
reviewed
Oct 12, 2023
leanprover-community-mathlib4-bot
added
merge-conflict
eric-wieser
reviewed
Oct 12, 2023
grunweg
added
awaiting-author
grunweg
force-pushed
the
MR-topology-gen-universes
branch
from
6c305e8
to
16439c8
Compare
grunweg
added
awaiting-review
and removed
awaiting-author
grunweg
changed the title
grunweg
changed the title
grunweg
force-pushed
the
MR-topology-gen-universes
branch
from
e2ff401
to
5a0396d
Compare
grunweg
force-pushed
the
MR-topology-gen-universes
branch
from
5a0396d
to
03523ec
Compare
|
Reverted one last round of not-useful changes, squashed and rebased. I am sorry for all the churn. |
|
I don't think it is useful to give nice names to universes. Quite the opposite in fact: having |
|
I see. I've heard two contradictory comments now, it's hard to adhere to both... I don't care about this strongly enough to pursue this further. If you do, feel free to re-use any of this work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly giving universes explicit/nicer names.
In two files (
ExtremallyDisconnectedandProperMap), remove autoImplicit true.(My understanding is that this is desired; happy to revert otherwise.)