[Merged by Bors] - feat(LinearAlgebra/Basis): commuting with basis elements places an element in the center #7833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eric-wieser
commented
Oct 22, 2023
eric-wieser
commented
…ement in the center
eric-wieser
added
awaiting-review
awaiting-CI
t-algebra
Vierkantor
reviewed
Nov 1, 2023
Comment on lines
+1406
to
+1407
| rw [← b.total_repr y, Finsupp.total_apply, Finsupp.sum, Finset.sum_mul, Finset.mul_sum] | ||
| simp_rw [mul_smul_comm, smul_mul_assoc, (h _).eq] |
There was a problem hiding this comment.
Way out of scope for this PR but: we should really have a nicer way to say that each element can be written as a sum of scaled basis vectors. Maybe a theorem along the lines of Basis.induction saying that P is always true on A whenever it is true on each b i and when it's closed under addition and scalar multiplication?
Vierkantor
approved these changes
Nov 1, 2023
leanprover-community-mathlib4-bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.